Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 14807005: Add a target all_webkit that depends on the old all_webkit and content_shell (Closed)

Created:
7 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 7 months ago
Reviewers:
abarth-chromium
CC:
chromium-reviews
Visibility:
Public.

Description

Add a target all_webkit that depends on the old all_webkit and content_shell BUG=111316 R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199616

Patch Set 1 #

Total comments: 2

Patch Set 2 : updates #

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M build/all.gyp View 1 2 2 chunks +9 lines, -1 line 0 comments Download
M build/all_android.gyp View 1 2 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
plz review
7 years, 7 months ago (2013-05-10 08:45:40 UTC) #1
abarth-chromium
https://codereview.chromium.org/14807005/diff/1/build/all.gyp File build/all.gyp (right): https://codereview.chromium.org/14807005/diff/1/build/all.gyp#newcode64 build/all.gyp:64: '../third_party/WebKit/Source/WebKit/chromium/TmpAll.gyp:*', As discussed in the other CL, I'd prefer ...
7 years, 7 months ago (2013-05-10 16:25:50 UTC) #2
jochen (gone - plz use gerrit)
PTAL
7 years, 7 months ago (2013-05-10 19:23:22 UTC) #3
abarth-chromium
LGTM
7 years, 7 months ago (2013-05-10 19:44:17 UTC) #4
jochen (gone - plz use gerrit)
7 years, 7 months ago (2013-05-11 18:51:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r199616 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698