tools/grit/grit/util.py - Issue 1480693003: Revert of New build flag system, convert Google Now flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/grit/grit/util.py

Issue 1480693003: Revert of New build flag system, convert Google Now flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/grit/grit/util.py

diff --git a/tools/grit/grit/util.py b/tools/grit/grit/util.py

index 93dce2610074cdef7fbc0190e3e36d3950d1d94f..b958bc22db2a011ea593977548dd9aa6bbd80e4a 100755

--- a/tools/grit/grit/util.py

+++ b/tools/grit/grit/util.py

@@ -483,8 +483,7 @@

'''Parses a define argument and returns the name and value.

The format is either "NAME=VAL" or "NAME", using True as the default value.

- Values of "1"/"true" and "0"/"false" are transformed to True and False

- respectively.

+ Values of "1" and "0" are transformed to True and False respectively.

Args:

define: a string of the form "NAME=VAL" or "NAME".

@@ -498,8 +497,8 @@

val = True

if len(parts) > 1:

val = parts[1]

- if val == "1" or val == "true": val = True

- elif val == "0" or val == "false": val = False

+ if val == "1": val = True

+ elif val == "0": val = False

return (name, val)

« no previous file with comments | « chrome/common_constants.gyp ('k') | tools/grit/grit_rule.gni » ('j') | no next file with comments »