build/gypi_to_gn.py - Issue 1480693003: Revert of New build flag system, convert Google Now flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/gypi_to_gn.py

Issue 1480693003: Revert of New build flag system, convert Google Now flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/gypi_to_gn.py

diff --git a/build/gypi_to_gn.py b/build/gypi_to_gn.py

index 6de1a6385df9d8c4d4d1b5b59ce652f0d93463d6..a107f94fcafd14c9883c57f4438f064fd8ded1e8 100644

--- a/build/gypi_to_gn.py

+++ b/build/gypi_to_gn.py

@@ -96,12 +96,10 @@

if 'target_conditions' in file_data:

del file_data['target_conditions']

- # Strip targets and includes in the toplevel, since some files define these

- # and we can't slurp them in.

+ # Strip targets in the toplevel, since some files define these and we can't

+ # slurp them in.

if 'targets' in file_data:

del file_data['targets']

- if 'includes' in file_data:

- del file_data['includes']

return file_data

« no previous file with comments | « build/config/features.gni ('k') | build/write_buildflag_header.py » ('j') | no next file with comments »