Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1480693002: Devtools: Fix SASS mappings with workers (Closed)

Created:
5 years ago by sergeyv
Modified:
5 years ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Devtools: Fix SASS mappings with workers BUG=449788 Committed: https://crrev.com/4aafb795fb5a9268e12e0502e15d337bebd470c7 Cr-Commit-Position: refs/heads/master@{#361788}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
sergeyv
5 years ago (2015-11-25 20:17:00 UTC) #2
lushnikov
lgtm
5 years ago (2015-11-25 22:20:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1480693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1480693002/1
5 years ago (2015-11-25 22:21:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios_rel_device_ninja on ...
5 years ago (2015-11-26 00:25:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1480693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1480693002/1
5 years ago (2015-11-26 00:42:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 01:51:10 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-26 01:51:44 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4aafb795fb5a9268e12e0502e15d337bebd470c7
Cr-Commit-Position: refs/heads/master@{#361788}

Powered by Google App Engine
This is Rietveld 408576698