chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.h - Issue 148063006: Put all scan results in the media galleries scan result dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.h

Issue 148063006: Put all scan results in the media galleries scan result dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/media_galleries_preferences_unittest.cc ('k') | chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.h

diff --git a/chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.h b/chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.h

index bdfb9560d3787f1567612932976f7f2a45caa7ba..adf905a46379129c606d3725d31026869066f624 100644

--- a/chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.h

+++ b/chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.h

@@ -104,8 +104,8 @@ class MediaGalleriesScanResultDialogController

MediaGalleriesScanResultDialogController*)> CreateDialogCallback;

typedef std::map<MediaGalleryPrefId, ScanResult> ScanResults;

- // Updates |results| from |preferences|. Will not add galleries from

- // |ignore_list| onto |results|.

+ // Updates |scan_results| from |preferences|. Will not add galleries from

+ // |ignore_list| onto |scan_results|.

static void UpdateScanResultsFromPreferences(

MediaGalleriesPreferences* preferences,

const extensions::Extension* extension,

@@ -129,8 +129,7 @@ class MediaGalleriesScanResultDialogController

void OnPreferencesInitialized();

// Used to keep the dialog in sync with the preferences.

- void OnPreferenceUpdate(const std::string& extension_id,

- MediaGalleryPrefId pref_id);

+ void OnPreferenceUpdate(const std::string& extension_id);

// Used to keep the dialog in sync with attached and detached devices.

void OnRemovableDeviceUpdate(const std::string device_id);