Put all scan results in the media galleries scan result dialog.

chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/run_loop.h"
@@ skipping 23 matching lines @@
 base::FilePath MakePath(std::string dir) {
 #if defined(OS_WIN)
   return base::FilePath(FILE_PATH_LITERAL("C:\\")).AppendASCII(dir);
 #elif defined(OS_POSIX)
   return base::FilePath(FILE_PATH_LITERAL("/")).Append(dir);
 #else
   NOTIMPLEMENTED();
 #endif
 }
 
-MediaGalleryPrefId AddScanResult(MediaGalleriesPreferences* gallery_prefs,
-                                 const std::string& path, int audio_count,
-                                 int image_count, int video_count) {
-  MediaGalleryPrefInfo gallery_info;
-  gallery_prefs->LookUpGalleryByPath(MakePath(path), &gallery_info);
-  return gallery_prefs->AddGallery(
-      gallery_info.device_id,
-      gallery_info.path,
-      MediaGalleryPrefInfo::kScanResult,
-      gallery_info.volume_label,
-      gallery_info.vendor_name,
-      gallery_info.model_name,
-      gallery_info.total_size_in_bytes,
-      gallery_info.last_attach_time,
-      audio_count, image_count, video_count);
-}
-
 class MockMediaGalleriesScanResultDialog
     : public MediaGalleriesScanResultDialog {
  public:
   typedef base::Callback<void(int update_count)> DialogDestroyedCallback;
 
   explicit MockMediaGalleriesScanResultDialog(
       const DialogDestroyedCallback& callback)
       : update_count_(0),
         dialog_destroyed_callback_(callback) {
   }
@@ skipping 47 matching lines @@
         CommandLine::ForCurrentProcess(), base::FilePath(), false);
 
     gallery_prefs_.reset(new MediaGalleriesPreferences(profile_.get()));
     base::RunLoop loop;
     gallery_prefs_->EnsureInitialized(loop.QuitClosure());
     loop.Run();
 
     std::vector<std::string> read_permissions;
     read_permissions.push_back(
         extensions::MediaGalleriesPermission::kReadPermission);
-    extension_ = AddMediaGalleriesApp("read", read_permissions, profile_.get());
+    extension_ = AddMediaGalleriesApp("allauto", read_permissions,

[tommycli, 2014/02/10 18:45:53]

why did the name change to 'allauto'?

[vandebo (ex-Chrome), 2014/02/11 19:19:31]

incompletely reverted change.  Fixed.

+                                      profile_.get());
   }
 
   virtual void TearDown() OVERRIDE {
     TestStorageMonitor::RemoveSingleton();
   }
 
   void StartDialog() {
     ASSERT_FALSE(controller_);
     controller_ = new MediaGalleriesScanResultDialogController(
         *extension_.get(),
@@ skipping 20 matching lines @@
   }
 
   extensions::Extension* extension() {
     return extension_.get();
   }
 
   MediaGalleriesPreferences* gallery_prefs() {
     return gallery_prefs_.get();
   }
 
+  MediaGalleryPrefId AddGallery(const std::string& path,
+                                MediaGalleryPrefInfo::Type type,
+                                int audio_count, int image_count,

[Lei Zhang, 2014/02/10 19:55:22]

Switch to MediaGalleryScanResult?

[vandebo (ex-Chrome), 2014/02/11 19:19:31]

For the testing code, it's easier to take three ints as args.

+                                int video_count) {
+    MediaGalleryPrefInfo gallery_info;
+    gallery_prefs_->LookUpGalleryByPath(MakePath(path), &gallery_info);
+    return gallery_prefs_->AddGallery(
+        gallery_info.device_id,
+        gallery_info.path,
+        type,
+        gallery_info.volume_label,
+        gallery_info.vendor_name,
+        gallery_info.model_name,
+        gallery_info.total_size_in_bytes,
+        gallery_info.last_attach_time,
+        audio_count, image_count, video_count);
+  }
+
+  MediaGalleryPrefId AddScanResult(const std::string& path, int audio_count,
+                                   int image_count, int video_count) {
+    return AddGallery(path, MediaGalleryPrefInfo::kScanResult, audio_count,
+                      image_count, video_count);
+  }
+
  private:
   MediaGalleriesScanResultDialog* CreateMockDialog(
       MediaGalleriesScanResultDialogController* controller) {
     EXPECT_FALSE(dialog_);
     dialog_update_count_at_destruction_ = 0;
     dialog_ = new MockMediaGalleriesScanResultDialog(base::Bind(
         &MediaGalleriesScanResultDialogControllerTest::OnDialogDestroyed,
         weak_factory_.GetWeakPtr()));
     return dialog_;
   }
@@ skipping 45 matching lines @@
   EXPECT_TRUE(dialog());
   EXPECT_EQ(0U, controller()->GetGalleryList().size());
 
   controller()->DialogFinished(true);
   EXPECT_FALSE(controller());
   EXPECT_FALSE(dialog());
   EXPECT_EQ(0, dialog_update_count_at_destruction());
 }
 
 TEST_F(MediaGalleriesScanResultDialogControllerTest, AddScanResults) {
   // Start with two scan results.

[tommycli, 2014/02/10 18:45:53]

comment is out of date if you intend to test with kAutodetected also

[vandebo (ex-Chrome), 2014/02/11 19:19:31]

Nope - we haven't done a scan, so all the existing galleries have no media files
in prefs.

-  MediaGalleryPrefId scan1 =
-      gallery_prefs()->AddGalleryByPath(MakePath("scan1"),
-                                        MediaGalleryPrefInfo::kScanResult);
-  MediaGalleryPrefId scan2 =
-      gallery_prefs()->AddGalleryByPath(MakePath("scan2"),
-                                        MediaGalleryPrefInfo::kScanResult);
+  MediaGalleryPrefId scan_id = AddScanResult("scan_id", 1, 0, 0);
+  MediaGalleryPrefId auto_id =
+      AddGallery("auto_id", MediaGalleryPrefInfo::kAutoDetected, 2, 0, 0);

[tommycli, 2014/02/10 18:45:53]

I think kAutoDetected Galleries need to have 0, 0, 0 counts.

[vandebo (ex-Chrome), 2014/02/11 19:19:31]

Why do you say that?

   EXPECT_EQ(0U, gallery_prefs()->GalleriesForExtension(*extension()).size());
 
   // Show the dialog, but cancel it.
   StartDialog();
   EXPECT_EQ(2U, controller()->GetGalleryList().size());
   controller()->DialogFinished(false);
   EXPECT_EQ(0U, gallery_prefs()->GalleriesForExtension(*extension()).size());
 
   // Show the dialog, unselect both and accept it.
   StartDialog();
   EXPECT_EQ(2U, controller()->GetGalleryList().size());
-  controller()->DidToggleGalleryId(scan1, false);
-  controller()->DidToggleGalleryId(scan2, false);
+  controller()->DidToggleGalleryId(scan_id, false);
+  controller()->DidToggleGalleryId(auto_id, false);
   controller()->DialogFinished(true);
   EXPECT_EQ(0U, gallery_prefs()->GalleriesForExtension(*extension()).size());
 
   // Show the dialog, leave one selected and accept it.
   StartDialog();
   EXPECT_EQ(2U, controller()->GetGalleryList().size());
-  controller()->DidToggleGalleryId(scan1, false);
+  controller()->DidToggleGalleryId(scan_id, false);
   controller()->DialogFinished(true);
   MediaGalleryPrefIdSet permitted =
       gallery_prefs()->GalleriesForExtension(*extension());
   ASSERT_EQ(1U, permitted.size());
-  EXPECT_EQ(scan2, *permitted.begin());
+  EXPECT_EQ(auto_id, *permitted.begin());
 
   // Show the dialog, toggle the remaining entry twice and then accept it.
   StartDialog();
   EXPECT_EQ(1U, controller()->GetGalleryList().size());
-  controller()->DidToggleGalleryId(scan1, false);
-  controller()->DidToggleGalleryId(scan1, true);
+  controller()->DidToggleGalleryId(scan_id, false);
+  controller()->DidToggleGalleryId(scan_id, true);
   controller()->DialogFinished(true);
   EXPECT_EQ(2U, gallery_prefs()->GalleriesForExtension(*extension()).size());
 }
 
 TEST_F(MediaGalleriesScanResultDialogControllerTest, Blacklisted) {
   // Start with two scan results.

[tommycli, 2014/02/10 18:45:53]

out of date

-  MediaGalleryPrefId scan1 =
-      gallery_prefs()->AddGalleryByPath(MakePath("scan1"),
-                                        MediaGalleryPrefInfo::kScanResult);
-  MediaGalleryPrefId scan2 =
-      gallery_prefs()->AddGalleryByPath(MakePath("scan2"),
-                                        MediaGalleryPrefInfo::kScanResult);
+  MediaGalleryPrefId scan_id = AddScanResult("scan_id", 1, 0, 0);
+  MediaGalleryPrefId auto_id =
+      AddGallery("auto_id", MediaGalleryPrefInfo::kAutoDetected, 2, 0, 0);

[tommycli, 2014/02/10 18:45:53]

0, 0, 0

   EXPECT_EQ(0U, gallery_prefs()->GalleriesForExtension(*extension()).size());
 
   // Show the dialog, but cancel it.
   StartDialog();
   EXPECT_EQ(2U, controller()->GetGalleryList().size());
   controller()->DialogFinished(false);
   EXPECT_EQ(0U, gallery_prefs()->GalleriesForExtension(*extension()).size());
 
   // Blacklist one and try again.
-  gallery_prefs()->ForgetGalleryById(scan2);
+  gallery_prefs()->ForgetGalleryById(scan_id);
   StartDialog();
   EXPECT_EQ(1U, controller()->GetGalleryList().size());
   controller()->DialogFinished(false);
 
   // Adding it as a user gallery should change its type.
-  gallery_prefs()->AddGalleryByPath(MakePath("scan2"),
-                                    MediaGalleryPrefInfo::kUserAdded);
+  AddGallery("scan_id", MediaGalleryPrefInfo::kUserAdded, 1, 0, 0);
   StartDialog();
-  EXPECT_EQ(1U, controller()->GetGalleryList().size());
+  EXPECT_EQ(2U, controller()->GetGalleryList().size());
 
   // Blacklisting the other while the dialog is open should remove it.
-  gallery_prefs()->ForgetGalleryById(scan1);
-  EXPECT_EQ(0U, controller()->GetGalleryList().size());
+  gallery_prefs()->ForgetGalleryById(auto_id);
+  EXPECT_EQ(1U, controller()->GetGalleryList().size());
   controller()->DialogFinished(false);
   EXPECT_EQ(0U, gallery_prefs()->GalleriesForExtension(*extension()).size());
   EXPECT_EQ(1, dialog_update_count_at_destruction());
 }
 
 TEST_F(MediaGalleriesScanResultDialogControllerTest, PrefUpdates) {
-  MediaGalleryPrefId selected =
-      gallery_prefs()->AddGalleryByPath(MakePath("selected"),
-                                        MediaGalleryPrefInfo::kScanResult);
-  MediaGalleryPrefId unselected =
-      gallery_prefs()->AddGalleryByPath(MakePath("unselected"),
-                                        MediaGalleryPrefInfo::kScanResult);
+  MediaGalleryPrefId selected = AddScanResult("selected", 1, 0, 0);
+  MediaGalleryPrefId unselected = AddScanResult("unselected", 1, 0, 0);
   MediaGalleryPrefId selected_add_permission =
-      gallery_prefs()->AddGalleryByPath(MakePath("selected_add_permission"),
-                                        MediaGalleryPrefInfo::kScanResult);
+      AddScanResult("selected_add_permission", 1, 0, 0);
   MediaGalleryPrefId unselected_add_permission =
-      gallery_prefs()->AddGalleryByPath(MakePath("unselected_add_permission"),
-                                        MediaGalleryPrefInfo::kScanResult);
+      AddScanResult("unselected_add_permission", 1, 0, 0);
   MediaGalleryPrefId selected_removed =
-      gallery_prefs()->AddGalleryByPath(MakePath("selected_removed"),
-                                        MediaGalleryPrefInfo::kScanResult);
+      AddScanResult("selected_removed", 1, 0, 0);
   MediaGalleryPrefId unselected_removed =
-      gallery_prefs()->AddGalleryByPath(MakePath("unselected_removed"),
-                                        MediaGalleryPrefInfo::kScanResult);
+      AddScanResult("unselected_removed", 1, 0, 0);
   MediaGalleryPrefId selected_update =
-      gallery_prefs()->AddGalleryByPath(MakePath("selected_update"),
-                                        MediaGalleryPrefInfo::kScanResult);
+      AddScanResult("selected_update", 1, 0, 0);
   MediaGalleryPrefId unselected_update =
-      gallery_prefs()->AddGalleryByPath(MakePath("unselected_update"),
-                                        MediaGalleryPrefInfo::kScanResult);
+      AddScanResult("unselected_update", 1, 0, 0);
 
   gallery_prefs()->AddGalleryByPath(MakePath("user"),
                                     MediaGalleryPrefInfo::kUserAdded);
   gallery_prefs()->AddGalleryByPath(MakePath("auto_detected"),
                                     MediaGalleryPrefInfo::kAutoDetected);
   MediaGalleryPrefId blacklisted =
       gallery_prefs()->AddGalleryByPath(MakePath("blacklisted"),
                                         MediaGalleryPrefInfo::kAutoDetected);
   gallery_prefs()->ForgetGalleryById(blacklisted);
   EXPECT_EQ(0U, gallery_prefs()->GalleriesForExtension(*extension()).size());
@@ skipping 38 matching lines @@
   EXPECT_EQ(5, dialog()->update_count());
   EXPECT_EQ(4U, controller()->GetGalleryList().size());
   const MediaGalleryPrefInfo& selected_update_info =
       gallery_prefs()->known_galleries().find(selected_update)->second;
   gallery_prefs()->AddGallery(
       selected_update_info.device_id, base::FilePath(),
       MediaGalleryPrefInfo::kScanResult,
       base::ASCIIToUTF16("Updated & Selected"),
       base::string16(), base::string16(), 0, base::Time(), 0, 0, 0);
   EXPECT_EQ(6, dialog()->update_count());
-  ASSERT_EQ(4U, controller()->GetGalleryList().size());
+  EXPECT_EQ(4U, controller()->GetGalleryList().size());

[Lei Zhang, 2014/02/10 19:55:22]

Why expect?

[vandebo (ex-Chrome), 2014/02/11 19:19:31]

Changed to assert

 
   MediaGalleriesScanResultDialogController::OrderedScanResults results =
       controller()->GetGalleryList();
   EXPECT_EQ(selected, results[0].pref_info.pref_id);
   EXPECT_TRUE(results[0].selected);
   EXPECT_EQ(selected_update, results[1].pref_info.pref_id);
   EXPECT_TRUE(results[1].selected);
   EXPECT_EQ(base::ASCIIToUTF16("Updated & Selected"),
             results[1].pref_info.volume_label);
   EXPECT_EQ(unselected, results[2].pref_info.pref_id);
   EXPECT_FALSE(results[2].selected);
   EXPECT_EQ(unselected_update, results[3].pref_info.pref_id);
   EXPECT_FALSE(results[3].selected);
   EXPECT_EQ(base::ASCIIToUTF16("Updated & Unselected"),
             results[3].pref_info.volume_label);
 
   controller()->DialogFinished(true);
   EXPECT_EQ(4U, gallery_prefs()->GalleriesForExtension(*extension()).size());
   StartDialog();
   EXPECT_EQ(2U, controller()->GetGalleryList().size());
   controller()->DialogFinished(false);
 }
 
 TEST_F(MediaGalleriesScanResultDialogControllerTest, ForgetGallery) {
   // Start with two scan results.
-  MediaGalleryPrefId scan1 =
-      gallery_prefs()->AddGalleryByPath(MakePath("scan1"),
-                                        MediaGalleryPrefInfo::kScanResult);
-  MediaGalleryPrefId scan2 =
-      gallery_prefs()->AddGalleryByPath(MakePath("scan2"),
-                                        MediaGalleryPrefInfo::kScanResult);
-  EXPECT_EQ(0U, gallery_prefs()->GalleriesForExtension(*extension()).size());
+  MediaGalleryPrefId scan1 = AddScanResult("scan1", 1, 0, 0);
+  MediaGalleryPrefId scan2 = AddScanResult("scan2", 2, 0, 0);
 
   // Remove one and then cancel.
   StartDialog();
   EXPECT_EQ(2U, controller()->GetGalleryList().size());
   controller()->DidForgetGallery(scan1);
   controller()->DialogFinished(false);
   EXPECT_EQ(0U, gallery_prefs()->GalleriesForExtension(*extension()).size());
 
   // Remove one and then have it blacklisted from prefs.
   StartDialog();
@@ skipping 13 matching lines @@
   controller()->DialogFinished(true);
   EXPECT_EQ(0U, gallery_prefs()->GalleriesForExtension(*extension()).size());
 
   // Check that nothing shows up.
   StartDialog();
   EXPECT_EQ(0U, controller()->GetGalleryList().size());
   controller()->DialogFinished(false);
 }
 
 TEST_F(MediaGalleriesScanResultDialogControllerTest, SortOrder) {
-  // Intentionally our of order numerically and alphabetically.
-  MediaGalleryPrefId third = AddScanResult(gallery_prefs(), "third", 2, 2, 2);
-  MediaGalleryPrefId second = AddScanResult(gallery_prefs(), "second", 9, 0, 0);
-  MediaGalleryPrefId first = AddScanResult(gallery_prefs(), "first", 8, 2, 3);
-  MediaGalleryPrefId fifth = AddScanResult(gallery_prefs(), "abb", 3, 0, 0);
-  MediaGalleryPrefId fourth = AddScanResult(gallery_prefs(), "aaa", 3, 0, 0);
+  // Intentionally out of order numerically and alphabetically.
+  MediaGalleryPrefId third = AddScanResult("third", 2, 2, 2);
+  MediaGalleryPrefId second =
+      AddGallery("second", MediaGalleryPrefInfo::kAutoDetected, 9, 0, 0);

[tommycli, 2014/02/10 18:45:53]

0, 0, 0

+  MediaGalleryPrefId first = AddScanResult("first", 8, 2, 3);
+  MediaGalleryPrefId fifth = AddScanResult("abb", 3, 0, 0);
+  MediaGalleryPrefId fourth = AddScanResult("aaa", 3, 0, 0);
 
   StartDialog();
   MediaGalleriesScanResultDialogController::OrderedScanResults results =
       controller()->GetGalleryList();
   ASSERT_EQ(5U, results.size());
   EXPECT_EQ(first, results[0].pref_info.pref_id);
   EXPECT_EQ(second, results[1].pref_info.pref_id);
   EXPECT_EQ(third, results[2].pref_info.pref_id);
   EXPECT_EQ(fourth, results[3].pref_info.pref_id);
   EXPECT_EQ(fifth, results[4].pref_info.pref_id);
   controller()->DialogFinished(false);
 }