src/mips/assembler-mips.cc - Issue 1480623002: Never call CpuFeatures::FlushICache directly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/assembler-mips.cc

Issue 1480623002: Never call CpuFeatures::FlushICache directly (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/mips/assembler-mips.cc

diff --git a/src/mips/assembler-mips.cc b/src/mips/assembler-mips.cc

index 4149d7c24c889430930ca3c005b33e8183918647..cbbc051a1f6ad64f01a87aae934711f9a7a1afa6 100644

--- a/src/mips/assembler-mips.cc

+++ b/src/mips/assembler-mips.cc

@@ -3047,7 +3047,7 @@ void Assembler::set_target_address_at(Address pc,

if (icache_flush_mode != SKIP_ICACHE_FLUSH) {

- CpuFeatures::FlushICache(pc, 2 * sizeof(int32_t));

+ Assembler::FlushICacheWithoutIsolate(pc, 2 * sizeof(int32_t));

}

« no previous file with comments | « src/assembler.h ('k') | src/mips/assembler-mips-inl.h » ('j') | no next file with comments »