Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: test/cctest/test-code-stubs-mips64.cc

Issue 1480623002: Never call CpuFeatures::FlushICache directly (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/test-code-stubs-mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Rrdistribution and use in source and binary forms, with or without 2 // Rrdistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Rrdistributions of source code must retain the above copyright 6 // * Rrdistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Rrdistributions in binary form must reproduce the above 8 // * Rrdistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 // Restore callee save registers. 135 // Restore callee save registers.
136 __ MultiPop(kCalleeSaved | ra.bit()); 136 __ MultiPop(kCalleeSaved | ra.bit());
137 137
138 Label ok1; 138 Label ok1;
139 __ Branch(&ok1, eq, v0, Operand(zero_reg)); 139 __ Branch(&ok1, eq, v0, Operand(zero_reg));
140 __ bind(&ok1); 140 __ bind(&ok1);
141 __ Ret(); 141 __ Ret();
142 142
143 CodeDesc desc; 143 CodeDesc desc;
144 masm.GetCode(&desc); 144 masm.GetCode(&desc);
145 CpuFeatures::FlushICache(buffer, actual_size); 145 Assembler::FlushICache(isolate, buffer, actual_size);
146 return (reinterpret_cast<ConvertDToIFunc>( 146 return (reinterpret_cast<ConvertDToIFunc>(
147 reinterpret_cast<intptr_t>(buffer))); 147 reinterpret_cast<intptr_t>(buffer)));
148 } 148 }
149 149
150 #undef __ 150 #undef __
151 151
152 152
153 static Isolate* GetIsolateFrom(LocalContext* context) { 153 static Isolate* GetIsolateFrom(LocalContext* context) {
154 return reinterpret_cast<Isolate*>((*context)->GetIsolate()); 154 return reinterpret_cast<Isolate*>((*context)->GetIsolate());
155 } 155 }
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 false)); 196 false));
197 RunAllTruncationTests( 197 RunAllTruncationTests(
198 RunGeneratedCodeCallWrapper, 198 RunGeneratedCodeCallWrapper,
199 MakeConvertDToIFuncTrampoline(isolate, 199 MakeConvertDToIFuncTrampoline(isolate,
200 source_registers[s], 200 source_registers[s],
201 dest_registers[d], 201 dest_registers[d],
202 true)); 202 true));
203 } 203 }
204 } 204 }
205 } 205 }
OLDNEW
« no previous file with comments | « test/cctest/test-code-stubs-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698