Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: test/cctest/test-code-stubs-mips.cc

Issue 1480623002: Never call CpuFeatures::FlushICache directly (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips64/macro-assembler-mips64.cc ('k') | test/cctest/test-code-stubs-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Rrdistribution and use in source and binary forms, with or without 2 // Rrdistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Rrdistributions of source code must retain the above copyright 6 // * Rrdistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Rrdistributions in binary form must reproduce the above 8 // * Rrdistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 // Restore callee save registers. 137 // Restore callee save registers.
138 __ MultiPop(kCalleeSaved | ra.bit()); 138 __ MultiPop(kCalleeSaved | ra.bit());
139 139
140 Label ok1; 140 Label ok1;
141 __ Branch(&ok1, eq, v0, Operand(zero_reg)); 141 __ Branch(&ok1, eq, v0, Operand(zero_reg));
142 __ bind(&ok1); 142 __ bind(&ok1);
143 __ Ret(); 143 __ Ret();
144 144
145 CodeDesc desc; 145 CodeDesc desc;
146 masm.GetCode(&desc); 146 masm.GetCode(&desc);
147 CpuFeatures::FlushICache(buffer, actual_size); 147 Assembler::FlushICache(isolate, buffer, actual_size);
148 return (reinterpret_cast<ConvertDToIFunc>( 148 return (reinterpret_cast<ConvertDToIFunc>(
149 reinterpret_cast<intptr_t>(buffer))); 149 reinterpret_cast<intptr_t>(buffer)));
150 } 150 }
151 151
152 #undef __ 152 #undef __
153 153
154 154
155 static Isolate* GetIsolateFrom(LocalContext* context) { 155 static Isolate* GetIsolateFrom(LocalContext* context) {
156 return reinterpret_cast<Isolate*>((*context)->GetIsolate()); 156 return reinterpret_cast<Isolate*>((*context)->GetIsolate());
157 } 157 }
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 false)); 197 false));
198 RunAllTruncationTests( 198 RunAllTruncationTests(
199 RunGeneratedCodeCallWrapper, 199 RunGeneratedCodeCallWrapper,
200 MakeConvertDToIFuncTrampoline(isolate, 200 MakeConvertDToIFuncTrampoline(isolate,
201 source_registers[s], 201 source_registers[s],
202 dest_registers[d], 202 dest_registers[d],
203 true)); 203 true));
204 } 204 }
205 } 205 }
206 } 206 }
OLDNEW
« no previous file with comments | « src/mips64/macro-assembler-mips64.cc ('k') | test/cctest/test-code-stubs-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698