Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Side by Side Diff: src/mips/assembler-mips.cc

Issue 1480623002: Never call CpuFeatures::FlushICache directly (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/assembler.h ('k') | src/mips/assembler-mips-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 3029 matching lines...) Expand 10 before | Expand all | Expand 10 after
3040 #endif 3040 #endif
3041 3041
3042 // Must use 2 instructions to insure patchable code => just use lui and ori. 3042 // Must use 2 instructions to insure patchable code => just use lui and ori.
3043 // lui rt, upper-16. 3043 // lui rt, upper-16.
3044 // ori rt rt, lower-16. 3044 // ori rt rt, lower-16.
3045 *p = LUI | rt_code | ((itarget & kHiMask) >> kLuiShift); 3045 *p = LUI | rt_code | ((itarget & kHiMask) >> kLuiShift);
3046 *(p + 1) = ORI | rt_code | (rt_code << 5) | (itarget & kImm16Mask); 3046 *(p + 1) = ORI | rt_code | (rt_code << 5) | (itarget & kImm16Mask);
3047 3047
3048 3048
3049 if (icache_flush_mode != SKIP_ICACHE_FLUSH) { 3049 if (icache_flush_mode != SKIP_ICACHE_FLUSH) {
3050 CpuFeatures::FlushICache(pc, 2 * sizeof(int32_t)); 3050 Assembler::FlushICacheWithoutIsolate(pc, 2 * sizeof(int32_t));
3051 } 3051 }
3052 } 3052 }
3053 3053
3054 } // namespace internal 3054 } // namespace internal
3055 } // namespace v8 3055 } // namespace v8
3056 3056
3057 #endif // V8_TARGET_ARCH_MIPS 3057 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/assembler.h ('k') | src/mips/assembler-mips-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698