Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: src/mips/assembler-mips-inl.h

Issue 1480623002: Never call CpuFeatures::FlushICache directly (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/assembler-mips.cc ('k') | src/mips/code-stubs-mips.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 // Copyright (c) 1994-2006 Sun Microsystems Inc. 2 // Copyright (c) 1994-2006 Sun Microsystems Inc.
3 // All Rights Reserved. 3 // All Rights Reserved.
4 // 4 //
5 // Redistribution and use in source and binary forms, with or without 5 // Redistribution and use in source and binary forms, with or without
6 // modification, are permitted provided that the following conditions are 6 // modification, are permitted provided that the following conditions are
7 // met: 7 // met:
8 // 8 //
9 // - Redistributions of source code must retain the above copyright notice, 9 // - Redistributions of source code must retain the above copyright notice,
10 // this list of conditions and the following disclaimer. 10 // this list of conditions and the following disclaimer.
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 85
86 86
87 // ----------------------------------------------------------------------------- 87 // -----------------------------------------------------------------------------
88 // RelocInfo. 88 // RelocInfo.
89 89
90 void RelocInfo::apply(intptr_t delta) { 90 void RelocInfo::apply(intptr_t delta) {
91 if (IsInternalReference(rmode_) || IsInternalReferenceEncoded(rmode_)) { 91 if (IsInternalReference(rmode_) || IsInternalReferenceEncoded(rmode_)) {
92 // Absolute code pointer inside code object moves with the code object. 92 // Absolute code pointer inside code object moves with the code object.
93 byte* p = reinterpret_cast<byte*>(pc_); 93 byte* p = reinterpret_cast<byte*>(pc_);
94 int count = Assembler::RelocateInternalReference(rmode_, p, delta); 94 int count = Assembler::RelocateInternalReference(rmode_, p, delta);
95 CpuFeatures::FlushICache(p, count * sizeof(uint32_t)); 95 Assembler::FlushICacheWithoutIsolate(p, count * sizeof(uint32_t));
96 } 96 }
97 } 97 }
98 98
99 99
100 Address RelocInfo::target_address() { 100 Address RelocInfo::target_address() {
101 DCHECK(IsCodeTarget(rmode_) || IsRuntimeEntry(rmode_)); 101 DCHECK(IsCodeTarget(rmode_) || IsRuntimeEntry(rmode_));
102 return Assembler::target_address_at(pc_, host_); 102 return Assembler::target_address_at(pc_, host_);
103 } 103 }
104 104
105 105
(...skipping 350 matching lines...) Expand 10 before | Expand all | Expand 10 after
456 EmittedCompactBranchInstruction(); 456 EmittedCompactBranchInstruction();
457 } 457 }
458 CheckTrampolinePoolQuick(); 458 CheckTrampolinePoolQuick();
459 } 459 }
460 460
461 461
462 } // namespace internal 462 } // namespace internal
463 } // namespace v8 463 } // namespace v8
464 464
465 #endif // V8_MIPS_ASSEMBLER_MIPS_INL_H_ 465 #endif // V8_MIPS_ASSEMBLER_MIPS_INL_H_
OLDNEW
« no previous file with comments | « src/mips/assembler-mips.cc ('k') | src/mips/code-stubs-mips.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698