Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 14806002: Fix shim_headers.gypi to properly set up include paths (Closed)

Created:
7 years, 7 months ago by Paweł Hajdan Jr.
Modified:
7 years, 7 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Visibility:
Public.

Description

Fix shim_headers.gypi to properly set up include paths when build/linux/unbundle is used. Previously gyp files would contain a giant conditional sections depending on use_system_foo condition. After extracting that to build/linux/unbundle, the nesting depth got reduced by one level, so one less "+" in this .gypi file (otherwise the section does not get applied at all). BUG=226860 R=rsleevi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197955

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/shim_headers.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paweł Hajdan Jr.
7 years, 7 months ago (2013-05-02 16:33:38 UTC) #1
Ryan Sleevi
LGTM, but it would be helpful if your commit message / review description explained more ...
7 years, 7 months ago (2013-05-02 19:08:56 UTC) #2
Paweł Hajdan Jr.
On 2013/05/02 19:08:56, Ryan Sleevi wrote: > LGTM, but it would be helpful if your ...
7 years, 7 months ago (2013-05-02 19:32:04 UTC) #3
Paweł Hajdan Jr.
7 years, 7 months ago (2013-05-02 19:36:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r197955 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698