Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 1480573002: Pass Isolate to CodeAgingHelper (Closed)

Created:
5 years ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Pass Isolate to CodeAgingHelper This is a preparation for requiring an isolate to construct a CodePatcher BUG=2487 R=epertoso@chromium.org LOG=n Committed: https://crrev.com/7ba6bb4e3b1510ce78280ad66dda2ecea0e2ec30 Cr-Commit-Position: refs/heads/master@{#32283}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M src/arm/codegen-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/codegen-arm64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/codegen-mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips64/codegen-mips64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ppc/codegen-ppc.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x87/codegen-x87.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years ago (2015-11-25 14:31:25 UTC) #1
epertoso
lgtm
5 years ago (2015-11-25 14:35:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1480573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1480573002/1
5 years ago (2015-11-25 14:39:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 15:24:54 UTC) #5
commit-bot: I haz the power
5 years ago (2015-11-25 15:25:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ba6bb4e3b1510ce78280ad66dda2ecea0e2ec30
Cr-Commit-Position: refs/heads/master@{#32283}

Powered by Google App Engine
This is Rietveld 408576698