Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1480523002: DevTools: follow up to r361550, fix the color picker background and allow for themed stylesheet mar… (Closed)

Created:
5 years ago by pfeldman
Modified:
5 years ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: follow up to r361550, fix the color picker background and allow for themed stylesheet markups. BUG=559524 TBR=dgozman NOTRY=true Committed: https://crrev.com/ce5d5a0de8cb81fa0ebd14278de19ed78ab2509b Cr-Commit-Position: refs/heads/master@{#361575}

Patch Set 1 #

Patch Set 2 : same #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -19 lines) Patch
M third_party/WebKit/Source/devtools/front_end/console/consoleView.css View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/spectrum.css View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js View 1 7 chunks +16 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/inspectorSyntaxHighlight.css View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
pfeldman
5 years ago (2015-11-25 04:30:10 UTC) #2
pfeldman
Landing this as TBR for greater Canary experience. Will address comments in follow up.
5 years ago (2015-11-25 04:31:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1480523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1480523002/1
5 years ago (2015-11-25 04:32:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1480523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1480523002/20001
5 years ago (2015-11-25 04:45:28 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-25 04:50:30 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-25 04:51:32 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ce5d5a0de8cb81fa0ebd14278de19ed78ab2509b
Cr-Commit-Position: refs/heads/master@{#361575}

Powered by Google App Engine
This is Rietveld 408576698