InstantExtended: Prevent spurious themechanged/mostvisitedchanged events

chrome/common/instant_types.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_INSTANT_TYPES_H_
 #define CHROME_COMMON_INSTANT_TYPES_H_
 
 #include <string>
 #include <utility>
 
@@ skipping 138 matching lines @@
   // The theme background image tiling is only valid if |theme_id| is valid.
   ThemeBackgroundImageTiling image_tiling;
 
   // The theme background image height.
   // Value is only valid if |theme_id| is valid.
   uint16 image_height;
 
   // True if theme has attribution logo.
   // Value is only valid if |theme_id| is valid.
   bool has_attribution;
+
+  bool operator==(const ThemeBackgroundInfo& other) const {

[samarth, 2013/05/03 21:24:42]

Don't overload operators please.  Just add a helper function in searchbox.cc.

+    return color_r == other.color_r &&
+        color_g == other.color_g &&
+        color_b == other.color_b &&
+        color_a == other.color_a &&
+        theme_id == other.theme_id &&
+        image_horizontal_alignment == other.image_horizontal_alignment &&
+        image_vertical_alignment == other.image_vertical_alignment &&
+        image_tiling == other.image_tiling &&
+        image_height == other.image_height &&
+        has_attribution == other.has_attribution;
+  }
+
+  bool operator!=(const ThemeBackgroundInfo& other) const {
+    return color_r != other.color_r ||
+        color_g != other.color_g ||
+        color_b != other.color_b ||
+        color_a != other.color_a ||
+        theme_id != other.theme_id ||
+        image_horizontal_alignment != other.image_horizontal_alignment ||
+        image_vertical_alignment != other.image_vertical_alignment ||
+        image_tiling != other.image_tiling ||
+        image_height != other.image_height ||
+        has_attribution != other.has_attribution;
+  }
 };
 
 struct InstantMostVisitedItem {
   // The URL of the Most Visited item.
   GURL url;
 
   // The title of the Most Visited page.  May be empty, in which case the |url|
   // is used as the title.
   string16 title;
 };
 
 // An InstantMostVisitedItem along with its assigned restricted ID.
 typedef std::pair<InstantRestrictedID, InstantMostVisitedItem>
     InstantMostVisitedItemIDPair;
 
 #endif  // CHROME_COMMON_INSTANT_TYPES_H_