Issue 14805002: Hamfistedly removed core dependence on images

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14805002: Hamfistedly removed core dependence on images (Closed)

Created:
7 years, 7 months ago by robertphillips

Modified:
7 years, 7 months ago

Reviewers:
scroggo

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

We cannot remove SkImageDecoder.cpp from Chrome's skia.gyp as long as core.gypi includes SkImage_Codec.cpp. It appears that the only consumer of SkImage_Codec right now is GM's image test. Skia compiles with this change. Note that there is a required follow on change to find a better place (then gmslides.gyp) for SkImage_Codec.cpp

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	gyp/core.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	gyp/gmslides.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

committed as r8947

Expand Messages | Collapse Messages