Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1480433003: [turbofan] Introduce representation-change.cc, move stuff there, minus dead code. (Closed)

Created:
5 years ago by Jarin
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce representation-change.cc, move stuff there, minus dead code. Committed: https://crrev.com/13b39259998de3038f7767468aa981cc349c5471 Cr-Commit-Position: refs/heads/master@{#32258}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+538 lines, -513 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/representation-change.h View 7 chunks +20 lines, -491 lines 0 comments Download
A src/compiler/representation-change.cc View 1 chunk +516 lines, -0 lines 1 comment Download
M src/compiler/simplified-lowering.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jarin
Could you take a look, please? Just removing or moving stuff around.
5 years ago (2015-11-25 09:26:58 UTC) #2
Benedikt Meurer
lgtm https://codereview.chromium.org/1480433003/diff/1/src/compiler/representation-change.cc File src/compiler/representation-change.cc (right): https://codereview.chromium.org/1480433003/diff/1/src/compiler/representation-change.cc#newcode475 src/compiler/representation-change.cc:475: return kTypeAny; // TODO(titzer): should be an error ...
5 years ago (2015-11-25 09:31:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1480433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1480433003/1
5 years ago (2015-11-25 09:35:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 09:59:07 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-25 09:59:29 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/13b39259998de3038f7767468aa981cc349c5471
Cr-Commit-Position: refs/heads/master@{#32258}

Powered by Google App Engine
This is Rietveld 408576698