Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1480433002: Add support for assert statements with messages to the analyzer. (Closed)

Created:
5 years ago by Paul Berry
Modified:
5 years ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for assert statements with messages to the analyzer. Support is disabled by default. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/9a08061581b29d5d31b2685a09230da31e2bad1a

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+287 lines, -12 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 9 chunks +50 lines, -2 lines 2 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 8 chunks +19 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 3 chunks +27 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 3 chunks +12 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/testing/ast_factory.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 chunk +76 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +30 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/utilities_test.dart View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Paul Berry
This is the same as https://codereview.chromium.org/1309543011/ (which was reviewed in September), except that: - It's ...
5 years ago (2015-11-24 21:22:03 UTC) #2
Brian Wilkerson
LGTM
5 years ago (2015-11-24 21:49:50 UTC) #3
scheglov
https://codereview.chromium.org/1480433002/diff/1/pkg/analyzer/lib/src/generated/ast.dart File pkg/analyzer/lib/src/generated/ast.dart (right): https://codereview.chromium.org/1480433002/diff/1/pkg/analyzer/lib/src/generated/ast.dart#newcode738 pkg/analyzer/lib/src/generated/ast.dart:738: * Return the messasge to report if the assertion ...
5 years ago (2015-11-24 23:01:24 UTC) #5
Paul Berry
Committed patchset #1 (id:1) manually as 9a08061581b29d5d31b2685a09230da31e2bad1a (presubmit successful).
5 years ago (2015-11-24 23:50:49 UTC) #6
Paul Berry
5 years ago (2015-11-24 23:54:39 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1480433002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/ast.dart (right):

https://codereview.chromium.org/1480433002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/ast.dart:738: * Return the messasge to report if
the assertion fails.
On 2015/11/24 23:01:24, scheglov wrote:
> messasge -> message

Done.

Powered by Google App Engine
This is Rietveld 408576698