Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1480423003: tools/gn: replace usage of linked_ptr by using scoped_ptr (Closed)

Created:
5 years ago by tfarina
Modified:
5 years ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina, scottmg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/gn: replace usage of linked_ptr by using scoped_ptr With C++11, we can use scoped_ptr in STL containers now. BUG=556939 TEST=gn gen + gn_unittests R=brettw@chromium.org Committed: https://crrev.com/4695e89361e0fdc2eaa3b3ba57362fa6e05f10cf Cr-Commit-Position: refs/heads/master@{#362520}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rm comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M tools/gn/loader_unittest.cc View 1 4 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
tfarina
5 years ago (2015-12-01 20:19:18 UTC) #1
brettw
lgtm https://codereview.chromium.org/1480423003/diff/1/tools/gn/loader_unittest.cc File tools/gn/loader_unittest.cc (right): https://codereview.chromium.org/1480423003/diff/1/tools/gn/loader_unittest.cc#newcode57 tools/gn/loader_unittest.cc:57: // Owning pointers. Can you delete this comment ...
5 years ago (2015-12-01 20:28:49 UTC) #2
tfarina
https://codereview.chromium.org/1480423003/diff/1/tools/gn/loader_unittest.cc File tools/gn/loader_unittest.cc (right): https://codereview.chromium.org/1480423003/diff/1/tools/gn/loader_unittest.cc#newcode57 tools/gn/loader_unittest.cc:57: // Owning pointers. On 2015/12/01 20:28:49, brettw wrote: > ...
5 years ago (2015-12-01 20:40:25 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1480423003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1480423003/20001
5 years ago (2015-12-01 20:52:42 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-01 21:32:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1480423003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1480423003/20001
5 years ago (2015-12-01 21:39:34 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-01 22:10:00 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-01 22:10:57 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4695e89361e0fdc2eaa3b3ba57362fa6e05f10cf
Cr-Commit-Position: refs/heads/master@{#362520}

Powered by Google App Engine
This is Rietveld 408576698