Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1480403002: Allow building non-XFA (master) on the XFA branch. (Closed)

Created:
5 years ago by Tom Sepez
Modified:
5 years ago
Reviewers:
Lei Zhang, Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Allow building non-XFA (master) on the XFA branch. This first pass is GYP-only, will do GN in the next CL. R=ochang@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/c46d0005880b24d38d9e7eab2f446e9724e93537

Patch Set 1 #

Patch Set 2 : warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -86 lines) Patch
M build/all.gyp View 1 chunk +3 lines, -1 line 0 comments Download
M core/src/fxge/ge/fx_ge_font.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 1 1 chunk +3 lines, -5 lines 0 comments Download
M pdfium.gyp View 12 chunks +39 lines, -25 lines 0 comments Download
M public/fpdf_formfill.h View 21 chunks +41 lines, -17 lines 0 comments Download
M public/fpdfview.h View 13 chunks +41 lines, -33 lines 0 comments Download
M samples/pdfium_test.cc View 4 chunks +12 lines, -1 line 0 comments Download
M samples/samples.gyp View 4 chunks +18 lines, -0 lines 0 comments Download
M testing/embedder_test.cpp View 3 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
ochang@ for review during thestig@ OOO.
5 years ago (2015-11-30 20:37:17 UTC) #2
Oliver Chang
lgtm got lost in my inbox, sorry for the late review!
5 years ago (2015-11-30 23:34:30 UTC) #3
Tom Sepez
5 years ago (2015-11-30 23:46:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c46d0005880b24d38d9e7eab2f446e9724e93537 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698