Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1480393004: Clean source maps during partition dispose. (Closed)

Created:
5 years ago by scheglov
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Clean source maps during partition dispose. This might fix the following exception: Dart analysis server, SDK version 1.14.0-edge.e3457758ed7e2b24263bcbd9831cd764ce9fd110, server version 1.12.0, FATAL error: Failed to perform operation: Instance of 'PerformAnalysisOperation' The null object does not have a getter 'modificationTime'. NoSuchMethodError: method not found: 'modificationTime' Receiver: null Arguments: [] R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/6f67abeaaa046e18bcb627cde4c37c2da49eff20

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -35 lines) Patch
M pkg/analyzer/lib/src/context/cache.dart View 10 chunks +27 lines, -34 lines 0 comments Download
M pkg/analyzer/test/src/context/cache_test.dart View 1 chunk +18 lines, -1 line 1 comment Download

Messages

Total messages: 4 (1 generated)
scheglov
5 years ago (2015-12-01 04:28:00 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/1480393004/diff/1/pkg/analyzer/test/src/context/cache_test.dart File pkg/analyzer/test/src/context/cache_test.dart (right): https://codereview.chromium.org/1480393004/diff/1/pkg/analyzer/test/src/context/cache_test.dart#newcode978 pkg/analyzer/test/src/context/cache_test.dart:978: expect(partition.pathToSource, isEmpty); expect(partition.entryMap, isEmpty); ?
5 years ago (2015-12-01 14:50:17 UTC) #2
scheglov
5 years ago (2015-12-01 15:55:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6f67abeaaa046e18bcb627cde4c37c2da49eff20 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698