Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1265)

Issue 1480393002: Fix unused function: SetBoolMetaData (Closed)

Created:
5 years ago by hans
Modified:
5 years ago
Reviewers:
Tom Hudson, tomhudson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix unused function: SetBoolMetaData To unbreak the Windows Clang build. From http://build.chromium.org/p/chromium.fyi/builders/CrWinClang%28dbg%29/builds/5143/steps/compile/logs/stdio: ..\..\skia\ext\platform_canvas.cc(19,6) : error: unused function 'SetBoolMetaData' [-Werror,-Wunused-function] void SetBoolMetaData(const SkCanvas& canvas, const char* key, bool value) { ^ ..\..\skia\ext\platform_canvas.cc(24,6) : error: unused function 'GetBoolMetaData' [-Werror,-Wunused-function] bool GetBoolMetaData(const SkCanvas& canvas, const char* key) { ^ BUG=82385 TBR=tomhudson Committed: https://chromium.googlesource.com/chromium/src/+/a042ba7e0ac563546841a9ddcc35967e8e25ef73

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M skia/ext/platform_canvas.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1480393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1480393002/1
5 years ago (2015-11-30 18:52:44 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a042ba7e0ac563546841a9ddcc35967e8e25ef73 Cr-Commit-Position: refs/heads/master@{#362178}
5 years ago (2015-11-30 19:07:27 UTC) #4
hans
Committed patchset #1 (id:1) manually as a042ba7e0ac563546841a9ddcc35967e8e25ef73 (presubmit successful).
5 years ago (2015-11-30 19:08:20 UTC) #6
Tom Hudson
5 years ago (2015-11-30 19:13:16 UTC) #7
Message was sent while issue was closed.
LGTM.

Ugh! Sorry Hans, that's the second time we've had a break due to that code,
presumably because we're getting a bad merge somehow.

Powered by Google App Engine
This is Rietveld 408576698