third_party/WebKit/Source/modules/filesystem/FileWriterSync.cpp - Issue 1480363003: Eliminate [LegacyInterfaceTypeChecking] for modules/filesystem bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/filesystem/FileWriterSync.cpp

Issue 1480363003: Eliminate [LegacyInterfaceTypeChecking] for modules/filesystem bindings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add assertions about writer error state Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/filesystem/DevToolsHostFileSystem.idl ('K') | « third_party/WebKit/Source/modules/filesystem/FileWriter.idl ('k') | third_party/WebKit/Source/modules/filesystem/FileWriterSync.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/filesystem/FileWriterSync.cpp

diff --git a/third_party/WebKit/Source/modules/filesystem/FileWriterSync.cpp b/third_party/WebKit/Source/modules/filesystem/FileWriterSync.cpp

index 656f144cb22eaf3c6dec8a2357843a12190f8c11..b147d96ad6f1c5bb4ab3bb365d02b1bd9d462580 100644

--- a/third_party/WebKit/Source/modules/filesystem/FileWriterSync.cpp

+++ b/third_party/WebKit/Source/modules/filesystem/FileWriterSync.cpp

@@ -42,12 +42,9 @@ namespace blink {

void FileWriterSync::write(Blob* data, ExceptionState& exceptionState)

{

+ ASSERT(data);

ASSERT(writer());

ASSERT(m_complete);

- if (!data) {

- exceptionState.throwDOMException(TypeMismatchError, FileError::typeMismatchErrorMessage);

- return;

- }

prepareForWrite();

writer()->write(position(), data->uuid());