third_party/WebKit/Source/modules/filesystem/FileWriter.cpp - Issue 1480363003: Eliminate [LegacyInterfaceTypeChecking] for modules/filesystem bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/filesystem/FileWriter.cpp

Issue 1480363003: Eliminate [LegacyInterfaceTypeChecking] for modules/filesystem bindings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add assertions about writer error state Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/filesystem/DevToolsHostFileSystem.idl ('K') | « third_party/WebKit/Source/modules/filesystem/EntrySync.idl ('k') | third_party/WebKit/Source/modules/filesystem/FileWriter.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/filesystem/FileWriter.cpp

diff --git a/third_party/WebKit/Source/modules/filesystem/FileWriter.cpp b/third_party/WebKit/Source/modules/filesystem/FileWriter.cpp

index bf9f657e32ffa9d82ac0cae0414546e328b64929..ea023996362959ee6354c233caecd56e0fe5eefa 100644

--- a/third_party/WebKit/Source/modules/filesystem/FileWriter.cpp

+++ b/third_party/WebKit/Source/modules/filesystem/FileWriter.cpp

@@ -95,16 +95,13 @@ bool FileWriter::hasPendingActivity() const

void FileWriter::write(Blob* data, ExceptionState& exceptionState)

{

+ ASSERT(data);

ASSERT(writer());

ASSERT(m_truncateLength == -1);

if (m_readyState == WRITING) {

setError(FileError::INVALID_STATE_ERR, exceptionState);

return;

}

- if (!data) {

- setError(FileError::TYPE_MISMATCH_ERR, exceptionState);

- return;

- }

if (m_recursionDepth > kMaxRecursionDepth) {

setError(FileError::SECURITY_ERR, exceptionState);

return;