third_party/WebKit/Source/modules/filesystem/DevToolsHostFileSystem.idl - Issue 1480363003: Eliminate [LegacyInterfaceTypeChecking] for modules/filesystem bindings

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/filesystem/DevToolsHostFileSystem.idl

Issue 1480363003: Eliminate [LegacyInterfaceTypeChecking] for modules/filesystem bindings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add assertions about writer error state Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/filesystem/workers/null-arguments-expected.txt ('K') | « third_party/WebKit/LayoutTests/fast/filesystem/workers/null-arguments-expected.txt ('k') | third_party/WebKit/Source/modules/filesystem/Entry.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 [	5 [

6 RuntimeEnabled=FileSystem,	6 RuntimeEnabled=FileSystem,

7 ] partial interface DevToolsHost {	7 ] partial interface DevToolsHost {

8 DOMFileSystem isolatedFileSystem(DOMString fileSystemId, DOMString registere dName);	8 DOMFileSystem isolatedFileSystem(DOMString fileSystemId, DOMString registere dName);

9 [LegacyInterfaceTypeChecking] void upgradeDraggedFileSystemPermissions(DOMFi leSystem domFileSystem);	9 void upgradeDraggedFileSystemPermissions(DOMFileSystem domFileSystem);
	philipj_slow 2015/12/01 09:00:24 Well this was odd, would this previously just cras Well this was odd, would this previously just crash at DevToolsHostFileSystem.cpp:30? jsbell 2015/12/01 19:50:32 Presumably. This is internal inspector code (not w Show quoted text On 2015/12/01 09:00:24, philipj wrote: > Well this was odd, would this previously just crash at > DevToolsHostFileSystem.cpp:30? Presumably. This is internal inspector code (not web-facing), and the only actual call appears to be at devtools/front_end/sources/SourcesPanel.js:1215 and it looks like it would never pass in null.
10 };	10 };

OLD	NEW