third_party/WebKit/LayoutTests/fast/filesystem/workers/null-arguments-expected.txt - Issue 1480363003: Eliminate [LegacyInterfaceTypeChecking] for modules/filesystem bindings

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/filesystem/workers/null-arguments-expected.txt

Issue 1480363003: Eliminate [LegacyInterfaceTypeChecking] for modules/filesystem bindings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add assertions about writer error state Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/filesystem/null-arguments.html ('K') | « third_party/WebKit/LayoutTests/fast/filesystem/workers/null-arguments.html ('k') | third_party/WebKit/Source/modules/filesystem/DevToolsHostFileSystem.idl » ('j') | third_party/WebKit/Source/modules/filesystem/DevToolsHostFileSystem.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 [Worker] This test tries calling various sync filesystem functions with null arg uments.

	2

	3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".

	4

	5

	6 Starting worker: ../resources/null-arguments-worker.js

	7 PASS [Worker] fileSystem.root.moveTo(null) threw exception TypeError: Failed to execute 'moveTo' on 'EntrySync': 2 arguments required, but only 1 present..
	philipj_slow 2015/12/01 09:00:24 This isn't actually testing the new TypeError, nee This isn't actually testing the new TypeError, needs the second argument. To make sure nothing was overlooked, maybe verify that all new tests fail without the IDL change. jsbell 2015/12/01 18:19:44 Thanks for catching this... the IDL doesn't match Show quoted text On 2015/12/01 09:00:24, philipj wrote: > This isn't actually testing the new TypeError, needs the second argument. To > make sure nothing was overlooked, maybe verify that all new tests fail without > the IDL change. Thanks for catching this... the IDL doesn't match the (dead) spec there; EntrySync's second arg is supposed to be `optional` too. And non-nullable - this is really crufty code. :P philipj_slow 2015/12/01 19:00:58 FileSystem sure needs some love to either revive o Show quoted text On 2015/12/01 18:19:44, jsbell wrote: > On 2015/12/01 09:00:24, philipj wrote: > > This isn't actually testing the new TypeError, needs the second argument. To > > make sure nothing was overlooked, maybe verify that all new tests fail without > > the IDL change. > > Thanks for catching this... the IDL doesn't match the (dead) spec there; > EntrySync's second arg is supposed to be `optional` too. And non-nullable - this > is really crufty code. :P FileSystem sure needs some love to either revive or kill it, but to be fair code all over the place gets optionality and nullability wrong :) jsbell 2015/12/01 19:50:32 Done. Show quoted text On 2015/12/01 09:00:24, philipj wrote: > This isn't actually testing the new TypeError, needs the second argument. To > make sure nothing was overlooked, maybe verify that all new tests fail without > the IDL change. Done.
	8 PASS [Worker] fileSystem.root.copyTo(null) threw exception TypeError: Failed to execute 'copyTo' on 'EntrySync': 2 arguments required, but only 1 present..

	9 PASS [Worker] writer.write(null) threw exception TypeError: Failed to execute 'w rite' on 'FileWriterSync': parameter 1 is not of type 'Blob'..

	10 PASS successfullyParsed is true

	11

	12 TEST COMPLETE

	13

OLD	NEW