third_party/WebKit/LayoutTests/fast/filesystem/null-arguments.html - Issue 1480363003: Eliminate [LegacyInterfaceTypeChecking] for modules/filesystem bindings

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/filesystem/null-arguments.html

Issue 1480363003: Eliminate [LegacyInterfaceTypeChecking] for modules/filesystem bindings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add assertions about writer error state Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/filesystem/null-arguments-expected.txt » ('j') | third_party/WebKit/LayoutTests/fast/filesystem/workers/null-arguments-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="../../resources/js-test.js"></script>

	4 <script src="resources/fs-test-util.js"></script>

	5 </head>

	6 <body>

	7 <script>

	8 description('This test tries calling various filesystem functions with null argu ments.');

	9

	10 function errorCallback(error)

	11 {

	12 debug("Error occured:" + error.name);
	philipj_slow 2015/12/01 09:00:24 space after comma makes output nicer space after comma makes output nicer jsbell 2015/12/01 19:50:32 Done. Show quoted text On 2015/12/01 09:00:24, philipj wrote: > space after comma makes output nicer Done.
	13 finishJSTest();

	14 }

	15

	16 function successCallback(fs)

	17 {

	18 window.fileSystem = fs;

	19 debug("Successfully obtained FileSystem:" + fileSystem.name);

	20

	21 shouldThrow("fileSystem.root.moveTo(null)");

	22 shouldThrow("fileSystem.root.copyTo(null)");

	23 fileSystem.root.getFile("/test", { create: true }, function(entry) {

	24 window.entry = entry;
	philipj_slow 2015/12/01 09:00:24 entry isn't used in any later should() so I don't entry isn't used in any later should() so I don't think it needs to sit on the global object. jsbell 2015/12/01 19:50:32 Done. Show quoted text On 2015/12/01 09:00:24, philipj wrote: > entry isn't used in any later should*() so I don't think it needs to sit on the > global object. Done.
	25 entry.createWriter(function(writer) {

	26 window.writer = writer;

	27 shouldBeNull("writer.error");

	28 shouldThrow("writer.write(null)");

	29 shouldBeNull("writer.error");

	30 finishJSTest();

	31 });

	32 });

	33 }

	34

	35 if (window.webkitRequestFileSystem) {

	36 webkitRequestFileSystem(window.TEMPORARY, 100, successCallback, errorCallbac k);

	37 window.jsTestIsAsync = true;

	38 } else {

	39 debug("This test requires FileSystem API support.");

	40 }

	41 </script>

	42 </body>

	43 </html>

OLD	NEW