Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1480353002: APIs which took colorPOI / coveragePOI pairs updated to take a GrPipelineOptimizations struct (Closed)

Created:
5 years ago by ethannicholas
Modified:
5 years ago
Reviewers:
egdaniel, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

APIs which took colorPOI / coveragePOI pairs updated to take a GrPipelineOptimizations struct TBR=bsalomon@google.com Committed: https://skia.googlesource.com/skia/+/de4166a3b45d859512e27e3257841f064d67549c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -198 lines) Patch
M include/gpu/GrXferProcessor.h View 7 chunks +8 lines, -12 lines 0 comments Download
M include/gpu/effects/GrCoverageSetOpXP.h View 1 chunk +2 lines, -4 lines 0 comments Download
M include/gpu/effects/GrPorterDuffXferProcessor.h View 2 chunks +4 lines, -8 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 3 chunks +7 lines, -9 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M src/gpu/GrPipeline.cpp View 2 chunks +3 lines, -6 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrPipelineBuilder.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M src/gpu/GrXferProcessor.cpp View 5 chunks +13 lines, -15 lines 0 comments Download
M src/gpu/effects/GrCoverageSetOpXP.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 7 chunks +11 lines, -16 lines 0 comments Download
M src/gpu/effects/GrDisableColorXP.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/gpu/effects/GrDisableColorXP.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 13 chunks +36 lines, -40 lines 0 comments Download
M tests/GrPorterDuffTest.cpp View 9 chunks +64 lines, -57 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
ethannicholas
5 years ago (2015-11-30 15:35:53 UTC) #2
egdaniel
lgtm
5 years ago (2015-11-30 15:49:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1480353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1480353002/1
5 years ago (2015-11-30 15:55:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/4266)
5 years ago (2015-11-30 15:56:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1480353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1480353002/1
5 years ago (2015-11-30 16:56:51 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-30 16:57:42 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/de4166a3b45d859512e27e3257841f064d67549c

Powered by Google App Engine
This is Rietveld 408576698