Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: src/arm/code-stubs-arm.cc

Issue 14803005: Erroneous pointer/smi comparison (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Now, in all platforms Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4732 matching lines...) Expand 10 before | Expand all | Expand 10 after
4743 __ b(eq, &done); 4743 __ b(eq, &done);
4744 __ CompareRoot(r3, Heap::kUndefinedValueRootIndex); 4744 __ CompareRoot(r3, Heap::kUndefinedValueRootIndex);
4745 __ b(eq, &done); 4745 __ b(eq, &done);
4746 4746
4747 // Special handling of the Array() function, which caches not only the 4747 // Special handling of the Array() function, which caches not only the
4748 // monomorphic Array function but the initial ElementsKind with special 4748 // monomorphic Array function but the initial ElementsKind with special
4749 // sentinels 4749 // sentinels
4750 Handle<Object> terminal_kind_sentinel = 4750 Handle<Object> terminal_kind_sentinel =
4751 TypeFeedbackCells::MonomorphicArraySentinel(masm->isolate(), 4751 TypeFeedbackCells::MonomorphicArraySentinel(masm->isolate(),
4752 LAST_FAST_ELEMENTS_KIND); 4752 LAST_FAST_ELEMENTS_KIND);
4753 __ JumpIfNotSmi(r3, &miss);
4753 __ cmp(r3, Operand(terminal_kind_sentinel)); 4754 __ cmp(r3, Operand(terminal_kind_sentinel));
4754 __ b(gt, &miss); 4755 __ b(gt, &miss);
4755 // Make sure the function is the Array() function 4756 // Make sure the function is the Array() function
4756 __ LoadArrayFunction(r3); 4757 __ LoadArrayFunction(r3);
4757 __ cmp(r1, r3); 4758 __ cmp(r1, r3);
4758 __ b(ne, &megamorphic); 4759 __ b(ne, &megamorphic);
4759 __ jmp(&done); 4760 __ jmp(&done);
4760 4761
4761 __ bind(&miss); 4762 __ bind(&miss);
4762 4763
(...skipping 2646 matching lines...) Expand 10 before | Expand all | Expand 10 after
7409 __ Jump(generic_construct_stub, RelocInfo::CODE_TARGET); 7410 __ Jump(generic_construct_stub, RelocInfo::CODE_TARGET);
7410 } 7411 }
7411 } 7412 }
7412 7413
7413 7414
7414 #undef __ 7415 #undef __
7415 7416
7416 } } // namespace v8::internal 7417 } } // namespace v8::internal
7417 7418
7418 #endif // V8_TARGET_ARCH_ARM 7419 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698