Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 1480273002: Rename IS_SPEC_OBJECT to IS_JS_RECEIVER in hydrogen. (Closed)

Created:
5 years ago by neis
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Rename IS_SPEC_OBJECT to IS_JS_RECEIVER in hydrogen. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/b7995d4bb4e518ebeb0c081703c2f27330bb1850 Cr-Commit-Position: refs/heads/master@{#32395}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M src/crankshaft/hydrogen.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
neis
5 years ago (2015-11-30 09:06:20 UTC) #1
Benedikt Meurer
LGTM.
5 years ago (2015-11-30 09:18:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1480273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1480273002/1
5 years ago (2015-11-30 09:19:32 UTC) #4
commit-bot: I haz the power
Failed to apply patch for src/crankshaft/hydrogen-instructions.cc: While running git apply --index -3 -p1; error: patch ...
5 years ago (2015-11-30 09:54:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1480273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1480273002/20001
5 years ago (2015-11-30 09:59:19 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-30 10:22:22 UTC) #11
commit-bot: I haz the power
5 years ago (2015-11-30 10:22:49 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b7995d4bb4e518ebeb0c081703c2f27330bb1850
Cr-Commit-Position: refs/heads/master@{#32395}

Powered by Google App Engine
This is Rietveld 408576698