Revert of MD Downloads: track downloads in C++, dispatch discrete JS updates

chrome/browser/resources/md_downloads/crisper.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 if (typeof Polymer == 'undefined')
   Polymer = {dom: 'shadow'};
 else
   console.error('Polymer is already defined.');
 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
@@ skipping 1513 matching lines @@
    * @param {string} chromeSendName
    * @return {function(string):void} A chrome.send() callback with curried name.
    */
   function chromeSendWithId(chromeSendName) {
     return function(id) { chrome.send(chromeSendName, [id]); };
   }
 
   /** @constructor */
   function ActionService() {}
 
-  /**
-   * @param {string} searchText Input typed by the user into a search box.
-   * @return {Array<string>} A list of terms extracted from |searchText|.
-   */
-  ActionService.splitTerms = function(searchText) {
-    /**
-     * @param {string} s
-     * @return {string} |s| without whitespace at the beginning or end.
-     */
-    function trim(s) { return s.trim(); }
-
-    /**
-     * @param {string} s
-     * @return {boolean} Whether |s| is empty.
-     */
-    function notEmpty(s) { return s.length > 0; }
-
-    // Split quoted terms (e.g., 'The "lazy" dog' => ['The', 'lazy', 'dog']).
-    return searchText.split(/"([^"]*)"/).map(trim).filter(notEmpty);
-  };
-
   ActionService.prototype = {
     /** @param {string} id ID of the download to cancel. */
     cancel: chromeSendWithId('cancel'),
 
     /** Instructs the browser to clear all finished downloads. */
     clearAll: function() {
       if (loadTimeData.getBoolean('allowDeletingHistory')) {
         chrome.send('clearAll');
         this.search('');
       }
@@ skipping 11 matching lines @@
     },
 
     /** @param {string} id ID of the download that the user started dragging. */
     drag: chromeSendWithId('drag'),
 
     /**
      * @return {boolean} Whether the user is currently searching for downloads
      *     (i.e. has a non-empty search term).
      */
     isSearching: function() {
-      return !!this.searchText_;
+      return this.searchText_.length > 0;
     },
 
     /** Opens the current local destination for downloads. */
     openDownloadsFolder: chrome.send.bind(chrome, 'openDownloadsFolder'),
 
     /**
      * @param {string} id ID of the download to run locally on the user's box.
      */
     openFile: chromeSendWithId('openFile'),
 
@@ skipping 11 matching lines @@
      *     warnings.
      */
     saveDangerous: chromeSendWithId('saveDangerous'),
 
     /** @param {string} searchText What to search for. */
     search: function(searchText) {
       if (this.searchText_ == searchText)
         return;
 
       this.searchText_ = searchText;
-      chrome.send('getDownloads', ActionService.splitTerms(searchText));
+
+      // Split quoted terms (e.g., 'The "lazy" dog' => ['The', 'lazy', 'dog']).
+      function trim(s) { return s.trim(); }
+      chrome.send('getDownloads', searchText.split(/"([^"]*)"/).map(trim));
     },
 
     /**
      * Shows the local folder a finished download resides in.
      * @param {string} id ID of the download to show.
      */
     show: chromeSendWithId('show'),
 
     /** Undo download removal. */
     undo: chrome.send.bind(chrome, 'undo'),
@@ skipping 15319 matching lines @@
 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('downloads', function() {
   var Manager = Polymer({
     is: 'downloads-manager',
 
     properties: {
       hasDownloads_: {
-        observer: 'hasDownloadsChanged_',
         type: Boolean,
+        value: false,
       },
 
       items_: {
         type: Array,
-        value: function() { return []; },
       },
     },
 
     hostAttributes: {
       loading: true,
     },
 
-    observers: [
-      'itemsChanged_(items_.*)',
-    ],
-
-    /** @private */
-    clearAll_: function() {
-      this.set('items_', []);
-    },
-
-    /** @private */
-    hasDownloadsChanged_: function() {
-      if (loadTimeData.getBoolean('allowDeletingHistory'))
-        this.$.toolbar.downloadsShowing = this.hasDownloads_;
-
-      if (this.hasDownloads_) {
-        this.$['downloads-list'].fire('iron-resize');
-      } else {
-        var isSearching = downloads.ActionService.getInstance().isSearching();
-        var messageToShow = isSearching ? 'noSearchResults' : 'noDownloads';
-        this.$['no-downloads'].querySelector('span').textContent =
-            loadTimeData.getString(messageToShow);
-      }
-    },
-
     /**
-     * @param {number} index
-     * @param {!Array<!downloads.Data>} list
-     * @private
-     */
-    insertItems_: function(index, list) {
-      this.splice.apply(this, ['items_', index, 0].concat(list));
-      this.updateHideDates_(index, index + list.length);
-      this.removeAttribute('loading');
-    },
-
-    /** @private */
-    itemsChanged_: function() {
-      this.hasDownloads_ = this.items_.length > 0;
-    },
-
-    /**
      * @param {Event} e
      * @private
      */
     onCanExecute_: function(e) {
       e = /** @type {cr.ui.CanExecuteEvent} */(e);
       switch (e.command.id) {
         case 'undo-command':
           e.canExecute = this.$.toolbar.canUndo();
           break;
         case 'clear-all-command':
@@ skipping 17 matching lines @@
     onLoad_: function() {
       cr.ui.decorate('command', cr.ui.Command);
       document.addEventListener('canExecute', this.onCanExecute_.bind(this));
       document.addEventListener('command', this.onCommand_.bind(this));
 
       // Shows all downloads.
       downloads.ActionService.getInstance().search('');
     },
 
     /**
-     * @param {number} index
+     * @return {number} The number of downloads shown on the page.
      * @private
      */
-    removeItem_: function(index) {
-      this.splice('items_', index, 1);
-      this.updateHideDates_(index, index);
+    size_: function() {
+      return this.items_.length;
     },
 
     /**
-     * @param {number} start
-     * @param {number} end
+     * Called when all items need to be updated.
+     * @param {!Array<!downloads.Data>} list A list of new download data.
      * @private
      */
-    updateHideDates_: function(start, end) {
-      for (var i = start; i <= end; ++i) {
-        var current = this.items_[i];
-        if (!current)
-          continue;
-        var prev = this.items_[i - 1];
-        current.hideDate = !!prev && prev.date_string == current.date_string;
+    updateAll_: function(list) {
+      /** @private {!Object<number>} */
+      this.idToIndex_ = {};
+
+      for (var i = 0; i < list.length; ++i) {
+        var data = list[i];
+
+        this.idToIndex_[data.id] = data.index = i;
+
+        var prev = list[i - 1];
+        data.hideDate = !!prev && prev.date_string == data.date_string;
       }
+
+      // TODO(dbeam): this resets the scroll position, which is a huge bummer.
+      // Removing something from the bottom of the list should not scroll you
+      // back to the top. The grand plan is to restructure how the C++ sends the
+      // JS data so that it only gets updates (rather than the most recent set
+      // of items). TL;DR - we can't ship with this bug.
+      this.items_ = list;
+
+      var hasDownloads = this.size_() > 0;
+      if (!hasDownloads) {
+        var isSearching = downloads.ActionService.getInstance().isSearching();
+        var messageToShow = isSearching ? 'noSearchResults' : 'noDownloads';
+        this.$['no-downloads'].querySelector('span').textContent =
+            loadTimeData.getString(messageToShow);
+      }
+      this.hasDownloads_ = hasDownloads;
+
+      if (loadTimeData.getBoolean('allowDeletingHistory'))
+        this.$.toolbar.downloadsShowing = this.hasDownloads_;
+
+      this.removeAttribute('loading');
     },
 
     /**
-     * @param {number} index
      * @param {!downloads.Data} data
      * @private
      */
-    updateItem_: function(index, data) {
+    updateItem_: function(data) {
+      var index = this.idToIndex_[data.id];
       this.set('items_.' + index, data);
-      this.updateHideDates_(index, index);
       this.$['downloads-list'].updateSizeForItem(index);
     },
   });
 
-  Manager.clearAll = function() {
-    Manager.get().clearAll_();
+  Manager.size = function() {
+    return document.querySelector('downloads-manager').size_();
   };
 
-  /** @return {!downloads.Manager} */
-  Manager.get = function() {
-    return queryRequiredElement('downloads-manager');
+  Manager.updateAll = function(list) {
+    document.querySelector('downloads-manager').updateAll_(list);
   };
 
-  Manager.insertItems = function(index, list) {
-    Manager.get().insertItems_(index, list);
+  Manager.updateItem = function(item) {
+    document.querySelector('downloads-manager').updateItem_(item);
   };
 
   Manager.onLoad = function() {
-    Manager.get().onLoad_();
-  };
-
-  Manager.removeItem = function(index) {
-    Manager.get().removeItem_(index);
-  };
-
-  Manager.updateItem = function(index, data) {
-    Manager.get().updateItem_(index, data);
+    document.querySelector('downloads-manager').onLoad_();
   };
 
   return {Manager: Manager};
 });
 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 window.addEventListener('load', downloads.Manager.onLoad);