Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1480263002: Revert of MD Downloads: track downloads in C++, dispatch discrete JS updates (Closed)

Created:
5 years ago by vabr (Chromium)
Modified:
5 years ago
Reviewers:
asanka, Dan Beam, dpapad
CC:
asanka, arv+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of MD Downloads: track downloads in C++, dispatch discrete JS updates (patchset #7 id:180002 of https://codereview.chromium.org/1428833005/ ) Reason for revert: This broke Android GN. More info on the bug. BUG=563357 Original issue's description: > MD Downloads: track downloads in C++, dispatch discrete JS updates > > Instead of both the C++ and the JS needing to create sparse and dense > representations of download items (and reconcile the differences in some > cases), just keep a sorted representation in C++ and send discrete, > positioned updates to the JS. This makes the C++ act more like a > controller and makes the JS simply respond to commands in a performant > way. > > R=asanka@chromium.org,dpapad@chromium.org > BUG=526577 > > Committed: https://crrev.com/099dfdd09d2dd8e2d8228c955a89069fc971d625 > Cr-Commit-Position: refs/heads/master@{#362063} TBR=asanka@chromium.org,dpapad@chromium.org,dbeam@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=526577 Committed: https://crrev.com/8f817f0d8f9b81ec1d0fdf1763fecfb85575574b Cr-Commit-Position: refs/heads/master@{#362108}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+537 lines, -1133 lines) Patch
M chrome/browser/download/download_query.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/download/download_query.cc View 2 chunks +29 lines, -31 lines 0 comments Download
M chrome/browser/resources/md_downloads/action_service.js View 3 chunks +4 lines, -29 lines 0 comments Download
D chrome/browser/resources/md_downloads/action_service_unittest.js View 1 chunk +0 lines, -37 lines 0 comments Download
M chrome/browser/resources/md_downloads/crisper.js View 5 chunks +59 lines, -104 lines 0 comments Download
D chrome/browser/resources/md_downloads/i18n.html View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_downloads/manager.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/manager.js View 2 chunks +47 lines, -75 lines 0 comments Download
D chrome/browser/ui/webui/md_downloads/downloads_list_tracker.h View 1 chunk +0 lines, -125 lines 0 comments Download
D chrome/browser/ui/webui/md_downloads/downloads_list_tracker.cc View 1 chunk +0 lines, -394 lines 0 comments Download
D chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc View 1 chunk +0 lines, -276 lines 0 comments Download
M chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.h View 5 chunks +44 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc View 10 chunks +349 lines, -19 lines 0 comments Download
M chrome/browser/ui/webui/md_downloads/md_downloads_ui.h View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/md_downloads/md_downloads_ui.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/test/data/webui/md_downloads/layout_tests.js View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
vabr (Chromium)
Created Revert of MD Downloads: track downloads in C++, dispatch discrete JS updates
5 years ago (2015-11-30 09:01:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1480263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1480263002/1
5 years ago (2015-11-30 09:03:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 09:04:11 UTC) #4
commit-bot: I haz the power
5 years ago (2015-11-30 09:05:02 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f817f0d8f9b81ec1d0fdf1763fecfb85575574b
Cr-Commit-Position: refs/heads/master@{#362108}

Powered by Google App Engine
This is Rietveld 408576698