Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1480243004: Dart: Lazy observatory asset loading. Option to disable the observatory. (Closed)

Created:
5 years ago by zra
Modified:
5 years ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Dart: Lazy observatory asset loading. Option to disable the observatory. Also adds a benchmark to track the startup cost of loading the http server for the observatory. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8182fbd9ac91eaacd492a35f17ee32a14200822f

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -11 lines) Patch
M mojo/dart/embedder/dart_controller.h View 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/dart/embedder/dart_controller.cc View 3 chunks +5 lines, -1 line 0 comments Download
M mojo/dart/embedder/vmservice/main.dart View 3 chunks +14 lines, -9 lines 0 comments Download
M mojo/tools/data/benchmarks View 1 1 chunk +18 lines, -0 lines 0 comments Download
M services/dart/content_handler_main.cc View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
zra
5 years ago (2015-12-03 16:48:20 UTC) #2
jamesr
lgtm delete the "BUG=" line if there's no bug
5 years ago (2015-12-03 18:56:06 UTC) #3
zra
5 years ago (2015-12-03 19:05:22 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
8182fbd9ac91eaacd492a35f17ee32a14200822f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698