Don't update the logical width when a scrollbar gets added

Don't update the logical width when a scrollbar gets added

This behavior is incorrect because the content width of a CSS box
*includes* the scrollbar width and should therefore not change.

See the layout test change in this patch -- Because min-width: 100px
includes the scrollbar, the clientWidth should be less than that.

R=szager@chromium.org,skobes@chromium.org
BUG=556717, 512229, 542197
Review URL: https://codereview.chromium.org/1459743002

Cr-Commit-Position: refs/heads/master@{#360529}
(cherry picked from commit 80a9f8200b090daac5d849bfe6e304a1eaa8f6cc)

Committed: https://chromium.googlesource.com/chromium/src/+/fa6315223cc325a4e41ffbc777dd567e323513ce

[cbiesinger, 2015-12-01 21:15:58]

Description was changed from

==========
Don't update the logical width when a scrollbar gets added

This behavior is incorrect because the content width of a CSS box
*includes* the scrollbar width and should therefore not change.

See the layout test change in this patch -- Because min-width: 100px
includes the scrollbar, the clientWidth should be less than that.

R=szager@chromium.org,skobes@chromium.org
BUG=556717,512229,542197

Review URL: https://codereview.chromium.org/1459743002

Cr-Commit-Position: refs/heads/master@{#360529}
(cherry picked from commit 80a9f8200b090daac5d849bfe6e304a1eaa8f6cc)
==========

to

==========
Don't update the logical width when a scrollbar gets added

This behavior is incorrect because the content width of a CSS box
*includes* the scrollbar width and should therefore not change.

See the layout test change in this patch -- Because min-width: 100px
includes the scrollbar, the clientWidth should be less than that.

R=szager@chromium.org,skobes@chromium.org
BUG=556717,512229,542197

Review URL: https://codereview.chromium.org/1459743002

Cr-Commit-Position: refs/heads/master@{#360529}
(cherry picked from commit 80a9f8200b090daac5d849bfe6e304a1eaa8f6cc)

Committed:
https://chromium.googlesource.com/chromium/src/+/fa6315223cc325a4e41ffbc777dd...
==========

[cbiesinger, 2015-12-01 21:15:58]

Committed patchset #1 (id:1) manually as
fa6315223cc325a4e41ffbc777dd567e323513ce.

[skobes, 2015-12-01 21:25:05]

lgtm

Nit: be careful saying "content width" as this is a different thing. 
LayoutBox::contentLogicalWidth() and LayoutBox::contentLogicalHeight() actually
do exclude the scrollbars.

But the patch looks correct given s/content width/logical width/ in change
description.

[cbiesinger, 2015-12-01 21:26:24]

On 2015/12/01 21:25:05, skobes wrote:
> lgtm
> 
> Nit: be careful saying "content width" as this is a different thing. 
> LayoutBox::contentLogicalWidth() and LayoutBox::contentLogicalHeight()
actually
> do exclude the scrollbars.
> 
> But the patch looks correct given s/content width/logical width/ in change
> description.

This was just a merge from trunk. But I was actually referring to the CSS
concept of content width, which does include the scrollbar, unlike our concept
of content width, which does not.