|
|
Created:
5 years ago by tyoshino (SeeGerritForStatus) Modified:
5 years ago CC:
cbentzel+watch_chromium.org, chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[net] docs: Update info in bug-triage-labels.md about Blink networking APIs
BUG=none
R=asanka,mmenke
Committed: https://crrev.com/c1ece4bd616db69b8aa2d025b50ff9ccac2196a7
Cr-Commit-Position: refs/heads/master@{#362381}
Patch Set 1 #
Messages
Total messages: 18 (8 generated)
Description was changed from ========== [net/docs] Update info in bug-triage-labels.md about Blink networking APIs BUG=none ========== to ========== [net] docs: Update info in bug-triage-labels.md about Blink networking APIs BUG=none ==========
tyoshino@chromium.org changed reviewers: + asanka@chromium.org
tyoshino@chromium.org changed reviewers: + yhirano@chromium.org
+yhirano
Hmm, I tried to review the rendered result, but it seems the Gitiles MD syntax is different from one of GitHub. asanka@, sorry but please tell me the right way to verify. I tried md_browser, too. But it also doesn't give the same result as Gitiles, especially about parsing the lines starting with :, i.e. ": Blah Blah..." https://chromium.googlesource.com/chromium/src/+/master/tools/md_browser/
asanka@chromium.org changed reviewers: + mmenke@chromium.org
On 2015/11/30 at 08:41:21, tyoshino wrote: > Hmm, I tried to review the rendered result, but it seems the Gitiles MD syntax is different from one of GitHub. asanka@, sorry but please tell me the right way to verify. > > I tried md_browser, too. But it also doesn't give the same result as Gitiles, especially about parsing the lines starting with :, i.e. ": Blah Blah..." > https://chromium.googlesource.com/chromium/src/+/master/tools/md_browser/ I'll pass the baton to mmenke@ since he's largely been overseeing the triage process and should approve the change to the labeling. WRT Markdown syntax: Gitiles uses a Markdown processor called Pegdown. Both Pegdown and Gitiles specifically support the definition list extension that we are using here. To make them work with md_browser.py, you'll need to add the 'markdown.extensions.def_list' to the list of extensions to enable in Python Markdown. You can do so with something like this: diff --git a/tools/md_browser/md_browser.py b/tools/md_browser/md_browser.py index 22864c2..3f0bac8 100644 --- a/tools/md_browser/md_browser.py +++ b/tools/md_browser/md_browser.py @@ -103,6 +103,7 @@ class Handler(SimpleHTTPServer.SimpleHTTPRequestHandler): extensions = [ 'markdown.extensions.fenced_code', 'markdown.extensions.tables', + 'markdown.extensions.def_list', 'markdown.extensions.toc', 'gitiles_ext_blocks', ] I'll fire up a CL to get definition lists working in md_browser.
On 2015/11/30 17:04:38, asanka wrote: > On 2015/11/30 at 08:41:21, tyoshino wrote: > > Hmm, I tried to review the rendered result, but it seems the Gitiles MD syntax > is different from one of GitHub. asanka@, sorry but please tell me the right way > to verify. > > > > I tried md_browser, too. But it also doesn't give the same result as Gitiles, > especially about parsing the lines starting with :, i.e. ": Blah Blah..." > > https://chromium.googlesource.com/chromium/src/+/master/tools/md_browser/ > > I'll pass the baton to mmenke@ since he's largely been overseeing the triage > process and should approve the change to the labeling. > > WRT Markdown syntax: Gitiles uses a Markdown processor called Pegdown. Both > Pegdown and Gitiles specifically support the definition list extension that we > are using here. To make them work with md_browser.py, you'll need to add the > 'markdown.extensions.def_list' to the list of extensions to enable in Python > Markdown. You can do so with something like this: > > diff --git a/tools/md_browser/md_browser.py b/tools/md_browser/md_browser.py > index 22864c2..3f0bac8 100644 > --- a/tools/md_browser/md_browser.py > +++ b/tools/md_browser/md_browser.py > @@ -103,6 +103,7 @@ class Handler(SimpleHTTPServer.SimpleHTTPRequestHandler): > extensions = [ > 'markdown.extensions.fenced_code', > 'markdown.extensions.tables', > + 'markdown.extensions.def_list', > 'markdown.extensions.toc', > 'gitiles_ext_blocks', > ] > > I'll fire up a CL to get definition lists working in md_browser. To test the changes, use ninja on net_docs.
These changes LGTM
On 2015/11/30 17:24:25, mmenke wrote: > On 2015/11/30 17:04:38, asanka wrote: > > On 2015/11/30 at 08:41:21, tyoshino wrote: > > > Hmm, I tried to review the rendered result, but it seems the Gitiles MD > syntax > > is different from one of GitHub. asanka@, sorry but please tell me the right > way > > to verify. > > > > > > I tried md_browser, too. But it also doesn't give the same result as > Gitiles, > > especially about parsing the lines starting with :, i.e. ": Blah Blah..." > > > https://chromium.googlesource.com/chromium/src/+/master/tools/md_browser/ > > > > I'll pass the baton to mmenke@ since he's largely been overseeing the triage > > process and should approve the change to the labeling. > > > > WRT Markdown syntax: Gitiles uses a Markdown processor called Pegdown. Both > > Pegdown and Gitiles specifically support the definition list extension that we > > are using here. To make them work with md_browser.py, you'll need to add the > > 'markdown.extensions.def_list' to the list of extensions to enable in Python > > Markdown. You can do so with something like this: > > > > diff --git a/tools/md_browser/md_browser.py b/tools/md_browser/md_browser.py > > index 22864c2..3f0bac8 100644 > > --- a/tools/md_browser/md_browser.py > > +++ b/tools/md_browser/md_browser.py > > @@ -103,6 +103,7 @@ class Handler(SimpleHTTPServer.SimpleHTTPRequestHandler): > > extensions = [ > > 'markdown.extensions.fenced_code', > > 'markdown.extensions.tables', > > + 'markdown.extensions.def_list', > > 'markdown.extensions.toc', > > 'gitiles_ext_blocks', > > ] > > > > I'll fire up a CL to get definition lists working in md_browser. > Thanks for the change! https://codereview.chromium.org/1488693002/ I can now see the def lists rendered correctly. > To test the changes, use ninja on net_docs. Thanks for the info! I'm creating a CL for net_docs.py to use def_list as well.
Description was changed from ========== [net] docs: Update info in bug-triage-labels.md about Blink networking APIs BUG=none ========== to ========== [net] docs: Update info in bug-triage-labels.md about Blink networking APIs BUG=none R=asanka,mmenke ==========
The CQ bit was checked by tyoshino@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1480223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1480223003/1
Message was sent while issue was closed.
Description was changed from ========== [net] docs: Update info in bug-triage-labels.md about Blink networking APIs BUG=none R=asanka,mmenke ========== to ========== [net] docs: Update info in bug-triage-labels.md about Blink networking APIs BUG=none R=asanka,mmenke ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [net] docs: Update info in bug-triage-labels.md about Blink networking APIs BUG=none R=asanka,mmenke ========== to ========== [net] docs: Update info in bug-triage-labels.md about Blink networking APIs BUG=none R=asanka,mmenke Committed: https://crrev.com/c1ece4bd616db69b8aa2d025b50ff9ccac2196a7 Cr-Commit-Position: refs/heads/master@{#362381} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c1ece4bd616db69b8aa2d025b50ff9ccac2196a7 Cr-Commit-Position: refs/heads/master@{#362381} |