Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1480213004: [runtime] [proxy] Make Object.prototype.hasOwnProperty support proxies (Closed)

Created:
5 years ago by Camillo Bruni
Modified:
5 years ago
Reviewers:
neis, Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] [proxy] Runtime_HasOwnProperty and thus Object.prototype.hasOwnProperty should use JSReceiver::HasOwnProperty for proxies. BUG=v8:1543 LOG=N Committed: https://crrev.com/f4d4051521e329d0f45b91426a92b6e99ac3cfe0 Cr-Commit-Position: refs/heads/master@{#32475}

Patch Set 1 #

Patch Set 2 : adding more tests #

Patch Set 3 : YAT #

Total comments: 1

Patch Set 4 : removing unused flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -9 lines) Patch
M src/js/v8natives.js View 1 1 chunk +1 line, -9 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/proxies-has-own-property.js View 1 2 3 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1480213004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1480213004/40001
5 years ago (2015-12-01 15:07:38 UTC) #3
Camillo Bruni
PTAL
5 years ago (2015-12-01 15:07:57 UTC) #5
Jakob Kummerow
LGTM with nit. https://codereview.chromium.org/1480213004/diff/40001/test/mjsunit/harmony/proxies-has-own-property.js File test/mjsunit/harmony/proxies-has-own-property.js (right): https://codereview.chromium.org/1480213004/diff/40001/test/mjsunit/harmony/proxies-has-own-property.js#newcode5 test/mjsunit/harmony/proxies-has-own-property.js:5: // Flags: --harmony-proxies --harmony-reflect nit: I ...
5 years ago (2015-12-01 15:33:46 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-01 15:58:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1480213004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1480213004/60001
5 years ago (2015-12-01 17:08:03 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-01 17:31:51 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-01 17:33:10 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f4d4051521e329d0f45b91426a92b6e99ac3cfe0
Cr-Commit-Position: refs/heads/master@{#32475}

Powered by Google App Engine
This is Rietveld 408576698