Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Unified Diff: base/files/scoped_temp_dir.cc

Issue 1480153002: Investigate Android build problems in review 1414463004. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Add //url dep on GN test_support target. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/files/scoped_temp_dir.cc
diff --git a/base/files/scoped_temp_dir.cc b/base/files/scoped_temp_dir.cc
index 27b758ed9038ea7181f561f80db3e3140bfd66a7..f1979508a2a0cbd2bdb5a16f4374245ad08758ad 100644
--- a/base/files/scoped_temp_dir.cc
+++ b/base/files/scoped_temp_dir.cc
@@ -10,11 +10,13 @@
namespace base {
ScopedTempDir::ScopedTempDir() {
+ LOG(ERROR) << "ScopedTempDir: ctor";
}
ScopedTempDir::~ScopedTempDir() {
+ LOG(ERROR) << "~ScopedTempDir: deleting temp dir";
if (!path_.empty() && !Delete())
- DLOG(WARNING) << "Could not delete temp dir in dtor.";
+ LOG(ERROR) << "Could not delete temp dir in dtor.";
}
bool ScopedTempDir::CreateUniqueTempDir() {
@@ -58,15 +60,20 @@ bool ScopedTempDir::Set(const FilePath& path) {
}
bool ScopedTempDir::Delete() {
- if (path_.empty())
+ if (path_.empty()) {
+ LOG(ERROR) << "Delete: path is empty -- returning";
return false;
+ }
+ LOG(ERROR) << "Delete: deleting file";
bool ret = base::DeleteFile(path_, true);
if (ret) {
// We only clear the path if deleted the directory.
+ LOG(ERROR) << "Delete: clearing path";
path_.clear();
}
+ LOG(ERROR) << "Delete: returning result: " << ret;
return ret;
}

Powered by Google App Engine
This is Rietveld 408576698