Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 148013010: Use PartitionAlloc for fastMalloc on Android (Closed)

Created:
6 years, 10 months ago by abarth-chromium
Modified:
6 years, 10 months ago
Reviewers:
tonyg
CC:
blink-reviews, Andrew Hayden (chromium.org)
Visibility:
Public.

Description

Use PartitionAlloc for fastMalloc on Android This switches fastMalloc to PartitionAlloc for Android. Previously, we only used PartitionAlloc for fastMalloc on Mac OS X. According to primiano's measurements, this CL should improve PLT performance on Android by 7%. See referenced bug for details. alexa_us on N10 with default alloc (without # ms/page PSS Dirty #1 227.6 60410 44904 #2 226.1 61547 46008 #3 222.4 55595 40072 #4 224.2 57293 41728 AVG 225.1 58711 43178 alexa_us on N10 with partalloc # ms/page PSS Dirty #1 204.68 54862 39456 #2 208.73 59240 43844 #3 208.57 55164 39788 #4 217.28 58280 42904 AVG 209.81 56886 41498 BUG=312725 R=tonyg@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166271

Patch Set 1 #

Patch Set 2 : Reupload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M Source/config.h View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
abarth-chromium
tonyg suggests that we try landing this CL and seeing how it impacts the perf ...
6 years, 10 months ago (2014-01-29 06:05:18 UTC) #1
tonyg
lgtm We can check in on this tomorrow to see how things are looking.
6 years, 10 months ago (2014-01-29 06:08:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/148013010/20001
6 years, 10 months ago (2014-01-29 06:09:02 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=9681
6 years, 10 months ago (2014-01-29 12:30:42 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-29 12:30:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/148013010/20001
6 years, 10 months ago (2014-01-29 16:15:21 UTC) #6
abarth-chromium
Committed patchset #2 manually as r166040 (presubmit successful).
6 years, 10 months ago (2014-01-29 18:19:26 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-29 18:22:23 UTC) #8
tonyg
[+andrewhayden, current perf sheriff] Andrew, we expect a variety of performance and memory changes from ...
6 years, 10 months ago (2014-01-29 18:51:15 UTC) #9
dglazkov
I think this may have broken android? ASSERTION FAILED: isPointerTypeAlignmentOkay(reinterpret_cast<TypePtr>(ptr)) ../../third_party/WebKit/Source/wtf/StdLibExtras.h(88) : TypePtr reinterpret_cast_ptr(void*) [with ...
6 years, 10 months ago (2014-01-29 20:51:14 UTC) #10
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 10 months ago (2014-02-02 18:39:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/148013010/20001
6 years, 10 months ago (2014-02-02 18:39:19 UTC) #12
abarth-chromium
The CQ bit was unchecked by abarth@chromium.org
6 years, 10 months ago (2014-02-02 18:42:08 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-02 18:42:14 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-02 18:42:16 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-02 18:42:18 UTC) #16
abarth-chromium
Committed patchset #2 manually as r166271 (presubmit successful).
6 years, 10 months ago (2014-02-02 18:46:32 UTC) #17
Chris Evans
6 years, 10 months ago (2014-02-03 03:43:46 UTC) #18
Message was sent while issue was closed.
On 2014/02/02 18:46:32, abarth wrote:
> Committed patchset #2 manually as r166271 (presubmit successful).

Ah thanks for landing it again! I was about to look into it myself :)

Powered by Google App Engine
This is Rietveld 408576698