Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 148013006: Mojo: re-org public/utility and public/environment (Closed)

Created:
6 years, 10 months ago by darin (slow to review)
Modified:
6 years, 10 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: re-org public/utility and public/environment The plan: - mojo/public/{subdir} contains public headers and scripts (if any). - mojo/public/{subdir}/lib contains private headers and .cc files (if any). - mojo/public/{subdir}/tests contains test files. Also, as part of this CL: 1- I simplified the TLS implementation in utility and hid it as an internal API. I'm not happy providing the API to third-parties as is. It was really intended to be used with LazyInstance, etc. Without that there is some subtlety with setup and teardown of the TLS slot. Hiding it avoids having to deal with this for now. 2- Deleted thread_local_unittest.cc as that was still coded against base/threading/thread_local.h (oops)! Besides that this test has a large dependency on base threading and synchronization primitives. It also isn't that useful to test our wrappers for TLS as they are such thin wrappers around the OS provided APIs. 3- Renamed environment/standalone to environment/lib for consistency. From the point of view of a third-party, lib is the better name for this directory. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247927

Patch Set 1 #

Patch Set 2 : tweak #

Patch Set 3 : updates #

Patch Set 4 : fix build #

Patch Set 5 : lower similarity factor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -1155 lines) Patch
M mojo/mojo_public.gypi View 1 2 4 chunks +11 lines, -12 lines 0 comments Download
A + mojo/public/environment/lib/DEPS View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/environment/lib/buffer_tls.cc View 1 2 3 1 chunk +11 lines, -8 lines 0 comments Download
A + mojo/public/environment/lib/buffer_tls_setup.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/environment/lib/default_async_waiter.cc View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/environment/lib/environment.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D mojo/public/environment/standalone/DEPS View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/public/environment/standalone/buffer_tls.cc View 1 2 1 chunk +0 lines, -34 lines 0 comments Download
D mojo/public/environment/standalone/buffer_tls_setup.h View 1 2 1 chunk +0 lines, -17 lines 0 comments Download
D mojo/public/environment/standalone/default_async_waiter.cc View 1 2 1 chunk +0 lines, -93 lines 0 comments Download
D mojo/public/environment/standalone/environment.cc View 1 2 1 chunk +0 lines, -22 lines 0 comments Download
A + mojo/public/environment/tests/async_waiter_unittest.cc View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/public/tests/environment/async_waiter_unittest.cc View 1 2 1 chunk +0 lines, -120 lines 0 comments Download
D mojo/public/tests/utility/run_loop_unittest.cc View 1 chunk +0 lines, -192 lines 0 comments Download
D mojo/public/tests/utility/thread_local_unittest.cc View 1 chunk +0 lines, -170 lines 0 comments Download
A + mojo/public/utility/lib/run_loop.cc View 1 2 2 chunks +9 lines, -14 lines 0 comments Download
A + mojo/public/utility/lib/thread_local.h View 1 2 3 4 1 chunk +42 lines, -21 lines 0 comments Download
A + mojo/public/utility/lib/thread_local_posix.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
A + mojo/public/utility/lib/thread_local_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D mojo/public/utility/run_loop.cc View 1 chunk +0 lines, -229 lines 0 comments Download
A + mojo/public/utility/tests/run_loop_unittest.cc View 9 chunks +14 lines, -14 lines 0 comments Download
M mojo/public/utility/thread_local.h View 1 2 1 chunk +0 lines, -126 lines 0 comments Download
D mojo/public/utility/thread_local_posix.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D mojo/public/utility/thread_local_win.cc View 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
darin (slow to review)
6 years, 10 months ago (2014-01-29 21:50:48 UTC) #1
darin (slow to review)
I couldn't get git to recognize that thread_local.h simply moved from utility/ to utility/lib/. Sigh.
6 years, 10 months ago (2014-01-29 21:57:51 UTC) #2
viettrungluu
LGTM (as far as I can tell -- rietveld isn't making it very easy to ...
6 years, 10 months ago (2014-01-29 22:11:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/148013006/70001
6 years, 10 months ago (2014-01-29 22:14:13 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 10:41:50 UTC) #5
Message was sent while issue was closed.
Change committed as 247927

Powered by Google App Engine
This is Rietveld 408576698