Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 148013004: Add UMA stats for ExtensionCache (Closed)

Created:
6 years, 11 months ago by Dmitry Polukhin
Modified:
6 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Add UMA stats for ExtensionCache Reported metrics: - number of extensions in cache - size of cache on disk BUG=316371 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247760 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248046

Patch Set 1 #

Total comments: 4

Patch Set 2 : comments resolved #

Patch Set 3 : comments resolved #

Total comments: 1

Patch Set 4 : fix compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -7 lines) Patch
M chrome/browser/extensions/updater/extension_cache_impl.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/extensions/updater/local_extension_cache.h View 1 2 3 4 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/extensions/updater/local_extension_cache.cc View 1 2 3 4 chunks +18 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Dmitry Polukhin
PTAL
6 years, 11 months ago (2014-01-27 22:30:47 UTC) #1
Joao da Silva
lgtm
6 years, 11 months ago (2014-01-28 10:09:20 UTC) #2
Dmitry Polukhin
jar@ please do OWNER review for tools/metrics/histograms
6 years, 10 months ago (2014-01-28 17:22:29 UTC) #3
Dmitry Polukhin
+ mpearson@ for OWNER review in tools/metrics/histograms/histograms.xml
6 years, 10 months ago (2014-01-28 21:19:23 UTC) #4
Mark P
https://codereview.chromium.org/148013004/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/148013004/diff/1/tools/metrics/histograms/histograms.xml#newcode4429 tools/metrics/histograms/histograms.xml:4429: + <summary>Number of cached extensions on disk.</summary> Please say ...
6 years, 10 months ago (2014-01-28 21:45:56 UTC) #5
Dmitry Polukhin
PTAL https://codereview.chromium.org/148013004/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/148013004/diff/1/tools/metrics/histograms/histograms.xml#newcode4429 tools/metrics/histograms/histograms.xml:4429: + <summary>Number of cached extensions on disk.</summary> On ...
6 years, 10 months ago (2014-01-28 21:59:14 UTC) #6
Dmitry Polukhin
Friendly ping, please take a look.
6 years, 10 months ago (2014-01-29 18:00:46 UTC) #7
Mark P
histograms.xml lgtm
6 years, 10 months ago (2014-01-29 18:06:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/148013004/40001
6 years, 10 months ago (2014-01-29 18:12:09 UTC) #9
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) remoting_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=218064
6 years, 10 months ago (2014-01-29 18:58:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/148013004/40001
6 years, 10 months ago (2014-01-29 19:09:11 UTC) #11
commit-bot: I haz the power
Change committed as 247760
6 years, 10 months ago (2014-01-29 22:35:36 UTC) #12
benwells
https://codereview.chromium.org/148013004/diff/40001/chrome/browser/extensions/updater/local_extension_cache.cc File chrome/browser/extensions/updater/local_extension_cache.cc (right): https://codereview.chromium.org/148013004/diff/40001/chrome/browser/extensions/updater/local_extension_cache.cc#newcode465 chrome/browser/extensions/updater/local_extension_cache.cc:465: const size_t size, This needs to be changed to ...
6 years, 10 months ago (2014-01-30 03:49:32 UTC) #13
benwells
On 2014/01/30 03:49:32, benwells wrote: > https://codereview.chromium.org/148013004/diff/40001/chrome/browser/extensions/updater/local_extension_cache.cc > File chrome/browser/extensions/updater/local_extension_cache.cc (right): > > https://codereview.chromium.org/148013004/diff/40001/chrome/browser/extensions/updater/local_extension_cache.cc#newcode465 > ...
6 years, 10 months ago (2014-01-30 03:49:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/148013004/60001
6 years, 10 months ago (2014-01-30 20:26:30 UTC) #15
commit-bot: I haz the power
Change committed as 248046
6 years, 10 months ago (2014-01-30 21:56:57 UTC) #16
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 21:56:58 UTC) #17
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698