Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: tools/dom/src/native_DOMPublic.dart

Issue 14801010: Fix dartium that was broken by Completer change. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/html/html.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/src/native_DOMPublic.dart
diff --git a/tools/dom/src/native_DOMPublic.dart b/tools/dom/src/native_DOMPublic.dart
index 4034d9165ebd438dde081c59beb1ab02a7f384de..5e96fcd4894c2a5a77c1b29a4b5ecb4a13606460 100644
--- a/tools/dom/src/native_DOMPublic.dart
+++ b/tools/dom/src/native_DOMPublic.dart
@@ -5,7 +5,7 @@
part of html;
_makeSendPortFuture(spawnRequest) {
- final completer = new Completer<SendPort>();
+ final completer = new Completer<SendPort>.sync();
Anton Muhin 2013/05/13 09:19:36 DBQ: do you know why it's needed?
floitsch 2013/05/13 09:21:21 Not completely. There must be something that requi
Anton Muhin 2013/05/14 13:55:33 Thanks a lot, Florian, I'll have a look. On 2013/
final port = new ReceivePort();
port.receive((result, _) {
completer.complete(result);
« no previous file with comments | « tests/html/html.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698