Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 14801009: [rAc Android dialog] Logo, banner, text, alignment fixes. (Closed)

Created:
7 years, 7 months ago by aruslan
Modified:
7 years, 7 months ago
CC:
chromium-reviews, Raman Kakilate, benquan, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman
Visibility:
Public.

Description

[rAc Android dialog] Logo, banner, text, alignment fixes. - All spinners have the same margins; - "Fetching payment details" instead of "Retrieving Wallet information"; - Wider spinner for account names; - Legal text placeholder (without links and preview); - Hide the header while in the Fetch mode; - Hide the Wallet logo while in the Autofill mode; - Cleaner Wallet logo (moved into a separate CL). BUG=237626, 232958 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198260

Patch Set 1 #

Patch Set 2 : Moving the bitmap to another CL to make trybots happy. #

Patch Set 3 : Fetching spinner adj. #

Patch Set 4 : Account chooser drop-down length. #

Patch Set 5 : Legal text. #

Patch Set 6 : Rebase . #

Patch Set 7 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -35 lines) Patch
M chrome/android/java/res/layout/autofill_dialog_content.xml View 1 2 1 chunk +8 lines, -7 lines 0 comments Download
M chrome/android/java/res/layout/autofill_dialog_title.xml View 1 2 3 4 1 chunk +8 lines, -6 lines 0 comments Download
M chrome/android/java/res/layout/autofill_general_layout.xml View 1 2 3 4 5 chunks +4 lines, -1 line 0 comments Download
M chrome/android/java/res/layout/autofill_menu_item.xml View 1 chunk +21 lines, -14 lines 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 chunk +7 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java View 1 2 3 4 5 6 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogGlue.java View 1 2 3 4 5 6 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogTitleView.java View 2 chunks +17 lines, -0 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/autofill/autofill_dialog_view_android.h View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc View 1 2 3 4 5 6 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
aruslan
Please take a look, thanks!
7 years, 7 months ago (2013-05-03 18:53:23 UTC) #1
aruslan
Please take a look, thanks!
7 years, 7 months ago (2013-05-03 21:41:20 UTC) #2
David Trainor- moved to gerrit
lgtm
7 years, 7 months ago (2013-05-03 23:33:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/14801009/28001
7 years, 7 months ago (2013-05-04 00:19:59 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-05-04 00:20:22 UTC) #5
Message was sent while issue was closed.
Change committed as 198260

Powered by Google App Engine
This is Rietveld 408576698