third_party/WebKit/Source/modules/crypto/Crypto.cpp - Issue 1480063002: Drop [LegacyInterfaceTypeChecking] for the Crypto API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/crypto/Crypto.cpp

Issue 1480063002: Drop [LegacyInterfaceTypeChecking] for the Crypto API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update tests Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/crypto/worker-random-values-types-expected.txt ('k') | third_party/WebKit/Source/modules/crypto/Crypto.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/crypto/Crypto.cpp

diff --git a/third_party/WebKit/Source/modules/crypto/Crypto.cpp b/third_party/WebKit/Source/modules/crypto/Crypto.cpp

index b535622a0d6f4547db88d4a9b2c0a505317ff457..4ac57bf195ac817d3b7984ac2724076787b59be3 100644

--- a/third_party/WebKit/Source/modules/crypto/Crypto.cpp

+++ b/third_party/WebKit/Source/modules/crypto/Crypto.cpp

@@ -55,10 +55,7 @@ bool isIntegerArray(DOMArrayBufferView* array)

DOMArrayBufferView* Crypto::getRandomValues(DOMArrayBufferView* array, ExceptionState& exceptionState)

{

- if (!array) {

- exceptionState.throwDOMException(TypeMismatchError, "The provided ArrayBufferView is null.");

- return nullptr;

- }

+ ASSERT(array);

if (!isIntegerArray(array)) {

exceptionState.throwDOMException(TypeMismatchError, String::format("The provided ArrayBufferView is of type '%s', which is not an integer array type.", array->typeName()));

return nullptr;