Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1480063002: Drop [LegacyInterfaceTypeChecking] for the Crypto API (Closed)

Created:
5 years ago by philipj_slow
Modified:
5 years ago
Reviewers:
eroman
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop [LegacyInterfaceTypeChecking] for the Crypto API BUG=561338 Committed: https://crrev.com/d3fff3ecaf7f55e110652ff989fe7f00440d58b7 Cr-Commit-Position: refs/heads/master@{#362247}

Patch Set 1 #

Patch Set 2 : update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M third_party/WebKit/LayoutTests/crypto/random-values-types-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/worker-random-values-types-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/crypto/Crypto.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/crypto/Crypto.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1480063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1480063002/20001
5 years ago (2015-11-27 20:58:32 UTC) #2
philipj_slow
PTAL
5 years ago (2015-11-27 20:58:34 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-27 22:22:57 UTC) #6
eroman
lgtm
5 years ago (2015-11-30 19:48:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1480063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1480063002/20001
5 years ago (2015-11-30 20:40:44 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-30 22:40:20 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-30 22:41:53 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d3fff3ecaf7f55e110652ff989fe7f00440d58b7
Cr-Commit-Position: refs/heads/master@{#362247}

Powered by Google App Engine
This is Rietveld 408576698