Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issue 148003005: Modify activity_log OWNERS files (Closed)

Created:
6 years, 10 months ago by felt
Modified:
6 years, 10 months ago
Reviewers:
Matt Perry, mvrable
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, felt, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Modify activity_log OWNERS files Add mvrable to activity_log OWNERS files, and add a note saying to only ask mpcomplete for review if felt and mvrable can't be reached. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251006

Patch Set 1 #

Patch Set 2 : rietveld is barfing; fix? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
chrome/browser/extensions/activity_log/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
chrome/browser/extensions/api/activity_log_private/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
felt
matt, thoughts on this change to the owners file?
6 years, 10 months ago (2014-02-13 00:41:54 UTC) #1
Matt Perry
Works for me :) LGTM
6 years, 10 months ago (2014-02-13 00:43:36 UTC) #2
felt
mvrable, you have about an hour to protest before i add you to this OWNERS ...
6 years, 10 months ago (2014-02-13 00:45:54 UTC) #3
mvrable
On 2014/02/13 00:45:54, felt wrote: > mvrable, you have about an hour to protest before ...
6 years, 10 months ago (2014-02-13 00:51:47 UTC) #4
felt
The CQ bit was checked by felt@chromium.org
6 years, 10 months ago (2014-02-13 00:52:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/148003005/50001
6 years, 10 months ago (2014-02-13 00:53:42 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 02:21:55 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) cacheinvalidation_unittests, cc_unittests, check_deps, check_deps2git, chromedriver_unittests, components_unittests, ...
6 years, 10 months ago (2014-02-13 02:21:56 UTC) #8
felt
The CQ bit was checked by felt@chromium.org
6 years, 10 months ago (2014-02-13 05:06:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/148003005/50001
6 years, 10 months ago (2014-02-13 05:06:59 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 14:59:46 UTC) #11
Message was sent while issue was closed.
Change committed as 251006

Powered by Google App Engine
This is Rietveld 408576698