Use white header for app windows part #2

This CL:
- Makes app windows and browser windows use different assets for the header and window controls
- Removes the separator for the window controls
- Changes FrameCaptionButton so that the buttons use separate assets for the button background and the button icon.

BUG=297187
TEST=Visual by kuscher@
NOTRY=true
R=jamescook@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253003

[pkotwicz, 2014-02-02 18:41:40]

James, can you please take a look?s

I will separate this CL into sub CLs which deal with the image assets only
before committing.

[James Cook, 2014-02-03 18:46:34]

LGTM with some suggestions

https://codereview.chromium.org/148003003/diff/2070001/ash/system/chromeos/ne...
File ash/system/chromeos/network/tray_sms.cc (right):

https://codereview.chromium.org/148003003/diff/2070001/ash/system/chromeos/ne...
ash/system/chromeos/network/tray_sms.cc:130: IDR_AURA_UBER_TRAY_SMS_DISMISS));
I take it this is because the close button can't be reused anymore?  Maybe put
that in the CL description.

https://codereview.chromium.org/148003003/diff/2070001/ash/wm/caption_buttons...
File ash/wm/caption_buttons/frame_caption_button_container_view.cc (left):

https://codereview.chromium.org/148003003/diff/2070001/ash/wm/caption_buttons...
ash/wm/caption_buttons/frame_caption_button_container_view.cc:30: const int
kDistanceBetweenButtons = -1;
Hooray, no more crazy overlap constant!

https://codereview.chromium.org/148003003/diff/2070001/ash/wm/header_painter.cc
File ash/wm/header_painter.cc (right):

https://codereview.chromium.org/148003003/diff/2070001/ash/wm/header_painter....
ash/wm/header_painter.cc:461: if (!top_edge.isNull()) {
There's always a top_edge, right?

https://codereview.chromium.org/148003003/diff/2070001/ash/wm/header_painter....
ash/wm/header_painter.cc:477: if (!left_edge.isNull()) {
ditto

https://codereview.chromium.org/148003003/diff/2070001/ash/wm/header_painter....
ash/wm/header_painter.cc:484: if (!right_edge.isNull()) {
ditto

https://codereview.chromium.org/148003003/diff/2070001/ash/wm/header_painter.h
File ash/wm/header_painter.h (right):

https://codereview.chromium.org/148003003/diff/2070001/ash/wm/header_painter....
ash/wm/header_painter.h:35: enum Mode {
Maybe comment that this is the window active state.

https://codereview.chromium.org/148003003/diff/2070001/chrome/browser/ui/view...
File chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc (right):

https://codereview.chromium.org/148003003/diff/2070001/chrome/browser/ui/view...
chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc:529: void
BrowserNonClientFrameViewAsh::GetFrameImageIds(
This function is long and complex. I suggest breaking it into smaller parts
somehow. For example, you could provide little functions for the
BrownserTypeNormal case, PackagedApp case, etc.

[pkotwicz, 2014-02-24 01:29:38]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-02-24 01:29:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/148003003/2300001

[pkotwicz, 2014-02-24 01:44:46]

The CQ bit was unchecked by pkotwicz@chromium.org

[pkotwicz, 2014-02-24 01:48:33]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-02-24 01:48:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/148003003/2280015

[commit-bot: I haz the power, 2014-02-24 05:27:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-24 05:27:13]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[pkotwicz, 2014-02-24 14:26:29]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-02-24 14:26:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/148003003/2280015

[commit-bot: I haz the power, 2014-02-24 20:17:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/148003003/2280015

[pkotwicz, 2014-02-24 20:26:43]

The CQ bit was unchecked by pkotwicz@chromium.org

[pkotwicz, 2014-02-24 20:27:19]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-02-24 21:01:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/148003003/2280015

[pkotwicz, 2014-02-24 22:06:20]

Committed patchset #4 manually as r253003 (presubmit successful).