src/snapshot/snapshot-common.cc - Issue 1480003002: [runtime] Replace global object link with native context link in all contexts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/snapshot/snapshot-common.cc

Issue 1480003002: [runtime] Replace global object link with native context link in all contexts. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add patch from Orion for interpreter cementation test. Disable obsolete/invalid tests. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/snapshot/snapshot-common.cc

diff --git a/src/snapshot/snapshot-common.cc b/src/snapshot/snapshot-common.cc

index 0b7e11d1ec4a0f225e88d9d5a2bce331ad2cb222..553d8b46fcce59d3041c0e7ead882cdc2a6f2d9d 100644

--- a/src/snapshot/snapshot-common.cc

+++ b/src/snapshot/snapshot-common.cc

@@ -82,10 +82,6 @@ MaybeHandle<Context> Snapshot::NewContextFromSnapshot(

Handle<Object> result;

if (!maybe_context.ToHandle(&result)) return MaybeHandle<Context>();

CHECK(result->IsContext());

- // If the snapshot does not contain a custom script, we need to update

- // the global object for exactly two contexts: the builtins context and the

- // script context that has the global "this" binding.

- CHECK(EmbedsScript(isolate) || (*outdated_contexts_out)->length() == 2);

if (FLAG_profile_deserialization) {

double ms = timer.Elapsed().InMillisecondsF();

int bytes = context_data.length();

« no previous file with comments | « src/snapshot/serialize.cc ('k') | src/x64/builtins-x64.cc » ('j') | no next file with comments »