[App Shell] Add dev tools for debugging

apps/shell/browser/shell_browser_main_parts.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "apps/shell/browser/shell_browser_main_parts.h"
 
 #include "apps/shell/browser/shell_browser_context.h"
 #include "apps/shell/browser/shell_extension_system.h"
 #include "apps/shell/browser/shell_extensions_browser_client.h"
 #include "apps/shell/browser/web_view_window.h"
 #include "apps/shell/common/shell_extensions_client.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "base/run_loop.h"
 #include "components/browser_context_keyed_service/browser_context_dependency_manager.h"
 #include "content/public/common/result_codes.h"
+#include "content/shell/browser/shell_devtools_delegate.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/renderer_startup_helper.h"
 #include "ui/aura/env.h"
 #include "ui/aura/root_window.h"
 #include "ui/aura/test/test_screen.h"
 #include "ui/base/ime/input_method_initializer.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/screen.h"
 #include "ui/views/test/test_views_delegate.h"
 #include "ui/views/views_delegate.h"
@@ skipping 78 matching lines @@
   extensions::ExtensionsBrowserClient::Set(extensions_browser_client_.get());
 
   // Create our custom ExtensionSystem first because other
   // BrowserContextKeyedServices depend on it.
   CreateExtensionSystem();
 
   EnsureBrowserContextKeyedServiceFactoriesBuilt();
   BrowserContextDependencyManager::GetInstance()->CreateBrowserContextServices(
       browser_context_.get());
 
+  devtools_delegate_.reset(
+      new content::ShellDevToolsDelegate(browser_context_.get()));
+
   CreateRootWindow();
   CreateViewsDelegate();
 
   const std::string kAppSwitch = "app";
   CommandLine* command_line = CommandLine::ForCurrentProcess();
   if (command_line->HasSwitch(kAppSwitch)) {
     base::FilePath app_dir(command_line->GetSwitchValueNative(kAppSwitch));
     base::FilePath app_absolute_dir = base::MakeAbsoluteFilePath(app_dir);
     extension_system_->LoadAndLaunchApp(app_absolute_dir);
   } else {
     // TODO(jamescook): For demo purposes create a window with a WebView just
     // to ensure that the content module is properly initialized.
     ShowWebViewWindow(browser_context_.get(),
                       wm_test_helper_->root_window()->window());
   }
 }
 
 bool ShellBrowserMainParts::MainMessageLoopRun(int* result_code)  {
   base::RunLoop run_loop;
   run_loop.Run();
   *result_code = content::RESULT_CODE_NORMAL_EXIT;
   return true;
 }
 
 void ShellBrowserMainParts::PostMainMessageLoopRun() {
+  if (devtools_delegate_)

[James Cook, 2014/02/10 20:31:23]

Why do you need the if()?  It looks like it should always exist.

[Haojian Wu, 2014/02/11 03:24:36]

Yes, in this code logic, it's always valid (it gets reset in
PreMainMessageLoopRun).
But I think it will be better to do this check although it's valid here  since
the pointer initialized NULL when constructing ShellBrowserMainParts object.

[James Cook, 2014/02/11 17:11:16]

I wouldn't do the if() because it confuses the reader -- it makes the reader
think there is a code path where the pointer will be NULL. For example, in
DestroyRootWindow() we don't check if wm_test_helper_ is NULL, even though it
starts as NULL in the constructor. Likewise in CreateExtensionSystem() we don't
check if browser_context_ is NULL.

+    devtools_delegate_->Stop();
   DestroyViewsDelegate();
   DestroyRootWindow();
   BrowserContextDependencyManager::GetInstance()->DestroyBrowserContextServices(
       browser_context_.get());
   extension_system_ = NULL;
   extensions::ExtensionsBrowserClient::Set(NULL);
   extensions_browser_client_.reset();
   browser_context_.reset();
   aura::Env::DeleteInstance();
 }
@@ skipping 37 matching lines @@
 }
 
 void ShellBrowserMainParts::CreateExtensionSystem() {
   DCHECK(browser_context_);
   extension_system_ = static_cast<ShellExtensionSystem*>(
       ExtensionSystem::Get(browser_context_.get()));
   extension_system_->InitForRegularProfile(true);
 }
 
 }  // namespace apps