Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add
Patch Set: Fix typo Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp
diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp
index 8fdb935c43cc41dc37c59eedf778f1aa1546ec21..aff2af60ce640eaebbbd905b40d5eed2f72009d5 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp
+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp
@@ -167,14 +167,14 @@ const AtomicString& ServiceWorkerGlobalScope::interfaceName() const
return EventTargetNames::ServiceWorkerGlobalScope;
}
-bool ServiceWorkerGlobalScope::dispatchEventInternal(PassRefPtrWillBeRawPtr<Event> event)
+DispatchEventResult ServiceWorkerGlobalScope::dispatchEventInternal(PassRefPtrWillBeRawPtr<Event> event)
{
m_eventNestingLevel++;
- bool result = WorkerGlobalScope::dispatchEventInternal(event.get());
+ DispatchEventResult dispatchResult = WorkerGlobalScope::dispatchEventInternal(event.get());
if (event->interfaceName() == EventNames::ErrorEvent && m_eventNestingLevel == 2)
m_hadErrorInTopLevelEventHandler = true;
m_eventNestingLevel--;
- return result;
+ return dispatchResult;
}
void ServiceWorkerGlobalScope::dispatchExtendableEvent(PassRefPtrWillBeRawPtr<Event> event, WaitUntilObserver* observer)

Powered by Google App Engine
This is Rietveld 408576698