Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add
Patch Set: Fix typo Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h
diff --git a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h
index 4153e44bf733c07c60ab6ed58a1e6f0fc348a47d..7fa821374467cd8a1fac9df5dd0dc9aa874765d0 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h
+++ b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h
@@ -6,6 +6,7 @@
#define RespondWithObserver_h
#include "core/dom/ContextLifecycleObserver.h"
+#include "core/events/EventTarget.h"
#include "modules/ModulesExport.h"
#include "platform/heap/Handle.h"
#include "public/platform/WebURLRequest.h"
@@ -28,7 +29,7 @@ public:
void contextDestroyed() override;
- void didDispatchEvent(bool defaultPrevented);
+ void didDispatchEvent(DispatchEventResult dispatchResult);
// Observes the promise and delays calling didHandleFetchEvent() until the
// given promise is resolved or rejected.

Powered by Google App Engine
This is Rietveld 408576698